Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1186] Remove Id input from QC flag creation page #1505

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Apr 11, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Removed Id input from QC flag creation page

Notable changes for developers:

  • NA

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Apr 11, 2024
@xsalonx xsalonx marked this pull request as ready for review April 11, 2024 09:08
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.40%. Comparing base (24ddf8b) to head (b50701c).
Report is 394 commits behind head on main.

Files Patch % Lines
...iews/QcFlagTypes/Create/QcFlagTypeCreationModel.js 0.00% 2 Missing ⚠️
...views/QcFlagTypes/Create/QcFlagTypeCreationPage.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   48.78%   44.40%   -4.38%     
==========================================
  Files         528      803     +275     
  Lines        7968    13443    +5475     
  Branches     1477     2398     +921     
==========================================
+ Hits         3887     5970    +2083     
- Misses       4081     7473    +3392     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@martinboulais martinboulais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the improvement of the creation in a separated PR, this should basically be a revert of the id one

@xsalonx xsalonx requested a review from martinboulais April 11, 2024 14:00
@xsalonx xsalonx force-pushed the xsalonx/QCF-TYPES/O2B-1186/remove-id branch from 1f2c6a7 to d1688e0 Compare April 12, 2024 10:12
@xsalonx xsalonx merged commit 9c383d3 into main Apr 12, 2024
6 of 8 checks passed
@xsalonx xsalonx deleted the xsalonx/QCF-TYPES/O2B-1186/remove-id branch April 12, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants