Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1186] Specify Id when creating QC flag type #1500

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Apr 10, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Added Id input for QC flag creation

Notable changes for developers:

  • NA

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Apr 10, 2024
@xsalonx xsalonx marked this pull request as ready for review April 10, 2024 09:59
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.08%. Comparing base (936da69) to head (c18b596).

Files Patch % Lines
...views/QcFlagTypes/Create/QcFlagTypeCreationPage.js 0.00% 2 Missing ⚠️
...iews/QcFlagTypes/Create/QcFlagTypeCreationModel.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
- Coverage   44.08%   44.08%   -0.01%     
==========================================
  Files         802      802              
  Lines       13346    13347       +1     
  Branches     2372     2372              
==========================================
  Hits         5884     5884              
- Misses       7462     7463       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@martinboulais martinboulais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have serious reserve on the fact to allow user to manually define values that has an auto increment in database.

@xsalonx xsalonx merged commit dac7be0 into main Apr 10, 2024
6 of 8 checks passed
@xsalonx xsalonx deleted the xsalonx/QCF-TYPES/O2B-1186/add-id branch April 10, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants