Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1120] Add QC flags creation API #1499

Merged
merged 47 commits into from
Apr 10, 2024

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Apr 9, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • Added QC flags creation API

Changes made to the database:

  • NA

@xsalonx xsalonx added the backend label Apr 9, 2024
@xsalonx xsalonx self-assigned this Apr 9, 2024
@xsalonx xsalonx marked this pull request as ready for review April 9, 2024 12:24
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 89.39394% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 44.30%. Comparing base (24ddf8b) to head (1d0795e).
Report is 389 commits behind head on main.

Files Patch % Lines
...erver/services/qualityControlFlag/QcFlagService.js 88.88% 6 Missing ⚠️
lib/server/controllers/qcFlag.controller.js 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   48.78%   44.30%   -4.48%     
==========================================
  Files         528      802     +274     
  Lines        7968    13412    +5444     
  Branches     1477     2391     +914     
==========================================
+ Hits         3887     5942    +2055     
- Misses       4081     7470    +3389     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/server/controllers/qcFlag.controller.js Outdated Show resolved Hide resolved
lib/server/services/qualityControlFlag/QcFlagService.js Outdated Show resolved Hide resolved
lib/server/services/qualityControlFlag/QcFlagService.js Outdated Show resolved Hide resolved
lib/server/services/qualityControlFlag/QcFlagService.js Outdated Show resolved Hide resolved
lib/server/services/qualityControlFlag/QcFlagService.js Outdated Show resolved Hide resolved
@xsalonx xsalonx requested a review from martinboulais April 9, 2024 14:11
@xsalonx xsalonx requested a review from martinboulais April 10, 2024 09:37
@xsalonx xsalonx requested a review from martinboulais April 10, 2024 11:40
@xsalonx xsalonx requested a review from martinboulais April 10, 2024 13:53
@xsalonx xsalonx requested a review from martinboulais April 10, 2024 15:21
@martinboulais martinboulais merged commit 0c6da29 into main Apr 10, 2024
7 of 8 checks passed
@martinboulais martinboulais deleted the xsalonx/QCF/O2B-1120/creation-API branch April 10, 2024 19:07
@martinboulais martinboulais changed the title [O2B-1200] Add QC flags creation API [O2B-1120] Add QC flags creation API Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants