-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O2B-1099] Move reset filter button on top of filter panel #1467
[O2B-1099] Move reset filter button on top of filter panel #1467
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 48.78% 43.73% -5.06%
==========================================
Files 528 832 +304
Lines 7968 13974 +6006
Branches 1477 2477 +1000
==========================================
+ Hits 3887 6111 +2224
- Misses 4081 7863 +3782 ☔ View full report in Codecov by Sentry. |
I pushed a simplification proposal on top of your work, feel free to tell me if you disagree and we can discuss about reverting it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with the exception of the extra CSS classes that are not bringing anything to the table. If you can remove those, we can then proceed with merging this PR
Co-authored-by: George Raduta <[email protected]>
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: