Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1099] Move reset filter button on top of filter panel #1467

Merged
merged 21 commits into from
May 10, 2024

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Mar 15, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Moved reset filtering button on top of filter panel and made it visible only if some filter is active

Notable changes for developers:

  • NA

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Mar 15, 2024
@xsalonx xsalonx marked this pull request as ready for review March 15, 2024 13:57
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 43.73%. Comparing base (24ddf8b) to head (9762969).
Report is 427 commits behind head on main.

❗ Current head 9762969 differs from pull request most recent head 388d028. Consider uploading reports for the commit 388d028 to get more accurate results

Files Patch % Lines
...c/components/Filters/common/filtersPanelPopover.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1467      +/-   ##
==========================================
- Coverage   48.78%   43.73%   -5.06%     
==========================================
  Files         528      832     +304     
  Lines        7968    13974    +6006     
  Branches     1477     2477    +1000     
==========================================
+ Hits         3887     6111    +2224     
- Misses       4081     7863    +3782     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais
Copy link
Collaborator

I pushed a simplification proposal on top of your work, feel free to tell me if you disagree and we can discuss about reverting it

graduta
graduta previously approved these changes Apr 24, 2024
Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the exception of the extra CSS classes that are not bringing anything to the table. If you can remove those, we can then proceed with merging this PR

@xsalonx xsalonx requested a review from graduta May 10, 2024 12:45
@xsalonx xsalonx merged commit ddb8474 into main May 10, 2024
6 checks passed
@xsalonx xsalonx deleted the xsalonx/MICS/O2B-1099/mode-reset-filter-btn-on-top branch May 10, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants