Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O2B-1152] Auto fill environments and lhcFills in log reply #1434

Merged
merged 6 commits into from
Mar 1, 2024
Merged

[O2B-1152] Auto fill environments and lhcFills in log reply #1434

merged 6 commits into from
Mar 1, 2024

Conversation

AnoeBanoe
Copy link
Contributor

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • When replying to a log, the environment and lhcFill id's are auto filled from their parent

Notable changes for developers:

  • New default method expectInputValue, does the same as expectInnerText but then for values instead of innerHTML

@AnoeBanoe AnoeBanoe self-assigned this Feb 29, 2024
martinboulais
martinboulais requested changes Mar 1, 2024
View reviewed changes
test/public/defaults.js Outdated Show resolved Hide resolved
test/public/defaults.js Outdated Show resolved Hide resolved
@martinboulais martinboulais changed the title [0B-1152] auto fill environments and lhcFills in log reply [O2B-1152] Auto fill environments and lhcFills in log reply Mar 1, 2024
@AnoeBanoe AnoeBanoe merged commit f83fff0 into main Mar 1, 2024
4 checks passed
@AnoeBanoe AnoeBanoe deleted the anhamdi/O2B-1152/auto-fill-log-reply branch March 1, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinboulais martinboulais martinboulais approved these changes

@graduta graduta Awaiting requested review from graduta graduta is a code owner

Assignees

@AnoeBanoe AnoeBanoe

Labels
frontend
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnoeBanoe @martinboulais