Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1100] Delete subsystems #1433

Merged
merged 12 commits into from
Jul 25, 2024
Merged

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • (Unused) Subsystems have been removed

@martinboulais martinboulais force-pushed the mboulais/O2B-1100/remove-subsystems branch from 7547993 to 972dfbc Compare April 30, 2024 10:30
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.76%. Comparing base (982d3a2) to head (3c6ed8d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   43.92%   43.76%   -0.17%     
==========================================
  Files         873      856      -17     
  Lines       14993    14728     -265     
  Branches     2853     2805      -48     
==========================================
- Hits         6586     6446     -140     
+ Misses       8407     8282     -125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there are still a few remaining places such as toTreeView.test.js that are still referring to subsystem. Could you please have a look?

proto/log.proto Show resolved Hide resolved
lib/database/models/log.js Show resolved Hide resolved
@martinboulais martinboulais force-pushed the mboulais/O2B-1100/remove-subsystems branch from 138fe17 to 40e1c0c Compare June 10, 2024 06:05
graduta
graduta previously approved these changes Jul 25, 2024
@xsalonx xsalonx self-requested a review July 25, 2024 09:52
xsalonx
xsalonx previously approved these changes Jul 25, 2024
@martinboulais martinboulais dismissed stale reviews from xsalonx and graduta via 66fced5 July 25, 2024 09:54
graduta
graduta previously approved these changes Jul 25, 2024
@martinboulais martinboulais merged commit ccbc4e9 into main Jul 25, 2024
22 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1100/remove-subsystems branch July 25, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants