Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1145] Add QC flags overview page #1390

Merged
merged 688 commits into from
Apr 10, 2024
Merged

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Feb 7, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Add QC flag overview pages

Notable changes for developers:

  • Added DPL detectors in detectorsProvider

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 209 lines in your changes are missing coverage. Please review.

Project coverage is 44.08%. Comparing base (772ca3b) to head (dcf425e).

Files Patch % Lines
...lic/views/QcFlags/Overview/QcFlagsOverviewModel.js 0.00% 38 Missing ⚠️
.../public/services/detectors/dplDetectorsProvider.js 0.00% 25 Missing ⚠️
...ags/ForDataPass/QcFlagsForDataPassOverviewModel.js 0.00% 20 Missing ⚠️
...ationPass/QcFlagsForSimulationPassOverviewModel.js 0.00% 20 Missing ⚠️
lib/public/views/QcFlags/QcFlagsModel.js 0.00% 20 Missing ⚠️
...lationPass/QcFlagsForSimulationPassOverviewPage.js 0.00% 18 Missing ⚠️
...lags/ForDataPass/QcFlagsForDataPassOverviewPage.js 0.00% 17 Missing ⚠️
.../ActiveColumns/runDetectorsAsyncQcActiveColumns.js 0.00% 12 Missing ⚠️
...iews/QcFlags/ActiveColumns/qcFlagsActiveColumns.js 0.00% 11 Missing ⚠️
lib/public/Model.js 0.00% 8 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
- Coverage   44.76%   44.08%   -0.68%     
==========================================
  Files         791      802      +11     
  Lines       13144    13346     +202     
  Branches     2353     2372      +19     
==========================================
  Hits         5884     5884              
- Misses       7260     7462     +202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsalonx xsalonx changed the title Xsalonx/qcf/o2 b 1145/implement view [O2B-1145] qcf view Feb 9, 2024
@xsalonx xsalonx requested a review from martinboulais April 9, 2024 13:36
@xsalonx xsalonx requested a review from martinboulais April 10, 2024 09:37
martinboulais
martinboulais previously approved these changes Apr 10, 2024
@xsalonx xsalonx merged commit 936da69 into main Apr 10, 2024
6 of 8 checks passed
@xsalonx xsalonx deleted the xsalonx/QCF/O2B-1145/implement-view branch April 10, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants