Skip to content

Commit

Permalink
rename
Browse files Browse the repository at this point in the history
  • Loading branch information
xsalonx committed Apr 11, 2024
1 parent 3610be9 commit f7d0963
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion lib/public/Model.js
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export default class Model extends Observable {
case 'qc-flags-for-data-pass':
this.qcFlags.loadForDataPassOverview(this.router.params);
break;
case 'qc-flag-for-data-pass-creation':
case 'qc-flag-creation-for-data-pass':
this.qcFlags.loadForDataPassCreation(this.router.params);
break;
case 'qc-flags-for-simulation-pass':
Expand Down
2 changes: 1 addition & 1 deletion lib/public/view.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export default (model) => {
'qc-flags-for-data-pass': QcFlagsForDataPassOverviewPage,
'qc-flags-for-simulation-pass': QcFlagsForSimulationPassOverviewPage,

'qc-flag-for-data-pass-creation': QcFlagsForDataPassCreationPage,
'qc-flag-creation-for-data-pass': QcFlagsForDataPassCreationPage,

statistics: StatisticsPage,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const QcFlagsForDataPassOverviewPage = ({ qcFlags: { forDataPassOverviewM
NotAsked: () => [commonTitle, tooltip(h('.f3', iconWarning()), 'No data pass data was asked for')],
}),
]),
frontLink(h('.flex-row.items-center.g1', [h('small', iconPlus()), 'QC']), 'qc-flag-for-data-pass-creation', {
frontLink(h('.flex-row.items-center.g1', [h('small', iconPlus()), 'QC']), 'qc-flag-creation-for-data-pass', {
runNumber,
dataPassId,
dplDetectorId,
Expand Down
12 changes: 6 additions & 6 deletions test/public/qcFlags/forDataPassCreation.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ module.exports = () => {
});

it('loads the page successfully', async () => {
const response = await goToPage(page, 'qc-flag-for-data-pass-creation', { queryParameters: {
const response = await goToPage(page, 'qc-flag-creation-for-data-pass', { queryParameters: {
dataPassId: 1,
runNumber: 106,
dplDetectorId: 1,
Expand All @@ -65,7 +65,7 @@ module.exports = () => {
});

it('can naviagate to runs per data pass page from breadcrumbs link', async () => {
await goToPage(page, 'qc-flag-for-data-pass-creation', { queryParameters: {
await goToPage(page, 'qc-flag-creation-for-data-pass', { queryParameters: {
dataPassId: 1,
runNumber: 106,
dplDetectorId: 1,
Expand All @@ -76,7 +76,7 @@ module.exports = () => {
});

it('can naviagate to run details page from breadcrumbs link', async () => {
await goToPage(page, 'qc-flag-for-data-pass-creation', { queryParameters: {
await goToPage(page, 'qc-flag-creation-for-data-pass', { queryParameters: {
dataPassId: 1,
runNumber: 106,
dplDetectorId: 1,
Expand All @@ -87,7 +87,7 @@ module.exports = () => {
});

it('should successfuly create run-based QC flag', async () => {
await goToPage(page, 'qc-flag-for-data-pass-creation', { queryParameters: {
await goToPage(page, 'qc-flag-creation-for-data-pass', { queryParameters: {
dataPassId: 1,
runNumber: 106,
dplDetectorId: 1,
Expand Down Expand Up @@ -116,7 +116,7 @@ module.exports = () => {
});

it('should successfuly create time-based QC flag', async () => {
await goToPage(page, 'qc-flag-for-data-pass-creation', { queryParameters: {
await goToPage(page, 'qc-flag-creation-for-data-pass', { queryParameters: {
dataPassId: 1,
runNumber: 106,
dplDetectorId: 1,
Expand Down Expand Up @@ -151,7 +151,7 @@ module.exports = () => {
});

it('should successfuly create run-based QC flag in case of missing', async () => {
await goToPage(page, 'qc-flag-for-data-pass-creation', { queryParameters: {
await goToPage(page, 'qc-flag-creation-for-data-pass', { queryParameters: {
dataPassId: 1,
runNumber: 106,
dplDetectorId: 1,
Expand Down

0 comments on commit f7d0963

Please sign in to comment.