fix

AliceO2Group · Apr 11, 2024 · e86fd13 · e86fd13
1 parent 202ee8a
commit e86fd13
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/lib/public/components/qcFlags/qcFlagTypesSelectionDropdownModel.js b/lib/public/components/qcFlags/qcFlagTypesSelectionDropdownModel.js
@@ -37,25 +37,28 @@ export class QcFlagTypesSelectionDropdownModel extends SelectionDropdownModel {
      * @inheritDoc
      */
     _initialize() {
-        qcFlagTypesProvider.notArchived$.getCurrent().match({
+        // eslint-disable-next-line require-jsdoc
+        const update = () => qcFlagTypesProvider.notArchived$.getCurrent().match({
             Success: (data) => {
-                this.availableOptions = RemoteData.success(data.map(({ id, name, method, bad, color }) => ({
+                this.setAvailableOptions(RemoteData.success(data.map(({ id, name, method, bad, color }) => ({
                     value: id,
                     original: { id, name, method, bad, color },
                     label: [
                         qcFlagTypeColoredBadge({ color }),
                         badge(h('span.flex-row.g1', method)),
-                    ] })));
+                    ] }))));
             },
             Failure: (errors) => {
-                this.availableOptions = RemoteData.failure(errors);
+                this.setAvailableOptions(RemoteData.failure(errors));
             },
             NotAsked: () => {
-                this.availableOptions = RemoteData.notAsked();
+                this.setAvailableOptions(RemoteData.notAsked());
             },
             Loading: () => {
-                this.availableOptions = RemoteData.loading();
+                this.setAvailableOptions(RemoteData.loading());
             },
         });
+        qcFlagTypesProvider.notArchived$.observe(update);
+        update();
     }
 }
diff --git a/lib/public/views/QcFlags/Create/QcFlagCreationModel.js b/lib/public/views/QcFlags/Create/QcFlagCreationModel.js
@@ -49,6 +49,7 @@ export class QcFlagCreationModel extends CreationModel {
         this._flagTypeSelectionModel = new QcFlagTypesSelectionDropdownModel({
             multiple: false,
         });
+        this._flagTypeSelectionModel.bubbleTo(this);
         this._flagTypeSelectionModel.visualChange$.bubbleTo(this);
 
         this._initilize();

diff --git a/lib/public/views/QcFlags/Create/qcFlagCreationComponent.js b/lib/public/views/QcFlags/Create/qcFlagCreationComponent.js
@@ -28,10 +28,10 @@ const qcFlagCreationForm = (creationModel) => {
     const rightPanel = [
         h(PanelComponent, [
             h(LabelPanelHeaderComponent, { for: 'flag-type' }, 'Flag Type'),
-            // selectionDropdown(
-            //     creationModel.flagTypesSelectionModel,
-            //     { selectorPrefix: 'flag-type' },
-            // ),
+            selectionDropdown(
+                creationModel.flagTypeSelectionModel,
+                { selectorPrefix: 'flag-type' },
+            ),
         ]),
         h(
             PanelComponent,