Fix even more random tests

AliceO2Group · May 2, 2024 · 3d9fda4 · 3d9fda4
1 parent 5499bf6
commit 3d9fda4
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 18 deletions.
diff --git a/test/public/lhcFills/detail.test.js b/test/public/lhcFills/detail.test.js
@@ -18,7 +18,7 @@ const {
     pressElement,
     goToPage,
     checkMismatchingUrlParam,
-    getPopoverContent, waitForTimeout,
+    getPopoverContent, waitForTimeout, waitForNavigation,
 } = require('../defaults.js');
 const { expect } = require('chai');
 
@@ -185,7 +185,7 @@ module.exports = () => {
     it('should successfully expose a button to create a new log related to the displayed fill', async () => {
         await goToPage(page, 'lhc-fill-details', { queryParameters: { fillNumber: 6 } });
 
-        await pressElement(page, '#create-log');
+        await waitForNavigation(page, () => pressElement(page, '#create-log'));
 
         expect(await checkMismatchingUrlParam(page, { page: 'log-create', lhcFillNumbers: '6' })).to.eql({});
 

diff --git a/test/public/logs/create.test.js b/test/public/logs/create.test.js
@@ -104,7 +104,7 @@ module.exports = () => {
 
         await waitForNavigation(page, () => pressElement(page, '#parent-log-details'));
 
-        expect(await checkMismatchingUrlParam(page, { ['log-details']: '1' }));
+        expect(await checkMismatchingUrlParam(page, { ['log-details']: '1' })).to.eql({});
     });
 
     it('Should successfully display the autofilled runs, environments and lhcFills when replying', async () => {

diff --git a/test/public/qcFlags/forDataPassCreation.test.js b/test/public/qcFlags/forDataPassCreation.test.js
@@ -75,7 +75,7 @@ module.exports = () => {
             },
         });
 
-        await pressElement(page, 'h2:nth-of-type(2)');
+        await waitForNavigation(page, () => pressElement(page, 'h2:nth-of-type(2)'));
         expect(await checkMismatchingUrlParam(page, { page: 'runs-per-data-pass', dataPassId: '1' })).to.be.eql({});
     });
 
@@ -88,7 +88,7 @@ module.exports = () => {
             },
         });
 
-        await pressElement(page, 'h2:nth-of-type(3)');
+        await waitForNavigation(page, () => pressElement(page, 'h2:nth-of-type(3)'));
         expect(await checkMismatchingUrlParam(page, { page: 'run-detail', runNumber: '106' })).to.be.eql({});
     });
 

diff --git a/test/public/qcFlags/forDataPassOverview.test.js b/test/public/qcFlags/forDataPassOverview.test.js
@@ -72,7 +72,7 @@ module.exports = () => {
             dplDetectorId: 1,
         } });
 
-        await pressElement(page, 'h2:nth-of-type(2)');
+        await waitForNavigation(page, () => pressElement(page, 'h2:nth-of-type(2)'));
         expect(await checkMismatchingUrlParam(page, { page: 'runs-per-data-pass', dataPassId: '1' })).to.be.eql({});
     });
 

diff --git a/test/public/qcFlags/forSimulationPassCreation.test.js b/test/public/qcFlags/forSimulationPassCreation.test.js
@@ -71,7 +71,7 @@ module.exports = () => {
             dplDetectorId: 1,
         } });
 
-        await pressElement(page, 'h2:nth-of-type(2)');
+        await waitForNavigation(page, () => pressElement(page, 'h2:nth-of-type(2)'));
         expect(await checkMismatchingUrlParam(page, { page: 'runs-per-simulation-pass', simulationPassId: '1' })).to.be.eql({});
     });
 
@@ -82,7 +82,7 @@ module.exports = () => {
             dplDetectorId: 1,
         } });
 
-        await pressElement(page, 'h2:nth-of-type(3)');
+        await waitForNavigation(page, () => pressElement(page, 'h2:nth-of-type(3)'));
         expect(await checkMismatchingUrlParam(page, { page: 'run-detail', runNumber: '106' })).to.be.eql({});
     });
 

diff --git a/test/public/qcFlags/forSimulationPassOverview.test.js b/test/public/qcFlags/forSimulationPassOverview.test.js
@@ -26,6 +26,7 @@ const {
 
 const { expect } = chai;
 const dateAndTime = require('date-and-time');
+const { waitForNavigation } = require('../defaults.js');
 
 module.exports = () => {
     let page;
@@ -71,7 +72,7 @@ module.exports = () => {
             dplDetectorId: 1,
         } });
 
-        await pressElement(page, 'h2:nth-of-type(2)');
+        await waitForNavigation(page, () => pressElement(page, 'h2:nth-of-type(2)'));
         expect(await checkMismatchingUrlParam(page, { page: 'runs-per-simulation-pass', simulationPassId: '1' })).to.be.eql({});
     });
 
@@ -82,7 +83,7 @@ module.exports = () => {
             dplDetectorId: 1,
         } });
 
-        await pressElement(page, 'h2:nth-of-type(3)');
+        await waitForNavigation(page, () => pressElement(page, 'h2:nth-of-type(3)'));
         expect(await checkMismatchingUrlParam(page, { page: 'run-detail', runNumber: '106' })).to.be.eql({});
     });
 

diff --git a/test/public/runs/detail.test.js b/test/public/runs/detail.test.js
@@ -13,7 +13,7 @@
 
 const chai = require('chai');
 const { defaultBefore, defaultAfter, expectInnerText, pressElement, getFirstRow } = require('../defaults');
-const { reloadPage, goToPage, fillInput, checkMismatchingUrlParam, getPopoverContent, waitForTimeout } = require('../defaults.js');
+const { reloadPage, goToPage, fillInput, checkMismatchingUrlParam, getPopoverContent, waitForTimeout, waitForNavigation } = require('../defaults.js');
 const { RunCalibrationStatus } = require('../../../lib/domain/enums/RunCalibrationStatus.js');
 const { getRun } = require('../../../lib/server/services/run/getRun.js');
 
@@ -429,8 +429,7 @@ module.exports = () => {
     it('should successfully expose a button to create a new log related to the displayed environment', async () => {
         await goToPage(page, 'run-detail', { queryParameters: { id: 106 } });
 
-        await pressElement(page, '#create-log');
-
+        await waitForNavigation(page, () => pressElement(page, '#create-log'));
         expect(await checkMismatchingUrlParam(page, { page: 'log-create', runNumbers: '106', lhcFillNumbers: '1' })).to.eql({});
 
         await page.waitForSelector('input#environments');

diff --git a/test/public/runs/runsPerSimulationPass.overview.test.js b/test/public/runs/runsPerSimulationPass.overview.test.js
@@ -30,6 +30,7 @@ const { waitForDownload } = require('../../utilities/waitForDownload');
 
 const { expect } = chai;
 const dateAndTime = require('date-and-time');
+const { waitForNavigation } = require('../defaults.js');
 
 const DETECTORS = [
     'CPV',
@@ -161,10 +162,8 @@ module.exports = () => {
         const runNumberLinkCellSelector = 'tbody tr:first-of-type a';
         const expectedRunNumber = await getInnerText(await page.$(runNumberLinkCellSelector));
 
-        await pressElement(page, runNumberLinkCellSelector);
-
-        expect(await checkMismatchingUrlParam(page, { page: 'run-detail', runNumber: expectedRunNumber }))
-            .to.be.eql({});
+        await waitForNavigation(page, () => pressElement(page, runNumberLinkCellSelector));
+        expect(await checkMismatchingUrlParam(page, { page: 'run-detail', runNumber: expectedRunNumber })).to.be.eql({});
     });
 
     it('should successfully export runs', async () => {
@@ -207,6 +206,6 @@ module.exports = () => {
             { runNumber: 54, runQuality: 'good' },
             { runNumber: 49, runQuality: 'good' },
         ]),
-        fs.unlinkSync(path.resolve(downloadPath, targetFileName));
+            fs.unlinkSync(path.resolve(downloadPath, targetFileName));
     });
 };