Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HybridGenerator: Asyncronous + parallel event generation #13788

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

sawenzel
Copy link
Collaborator

This introduces:

  • asyncronous event generation
  • possibility for parallel event generation

This is useful for:

  • hiding latency (IO) of certain generators
  • decoupling the actual work from the call sequence into HybridGenerator
  • collaboration from multiple clones of the same generator to generate a certain number of events

The implementation relies on tbb::task_arena and input/output queues for decoupling the task_arena from the HybridGenerator thread.

Small adjustments to seeding of Pythia8 in order
to avoid same seeds in multiple parallel Pythia instances.

@sawenzel sawenzel requested a review from jackal1-66 as a code owner December 10, 2024 13:43
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

This introduces:
* asyncronous event generation
* possibility for parallel event generation

This is useful for:
* hiding latency (IO) of certain generators
* decoupling the actual work from the call sequence into HybridGenerator
* collaboration from multiple clones of the same generator to generate
  a certain number of events

The implementation relies on tbb::task_arena and input/output queues
for decoupling the task_arena from the HybridGenerator thread.

An example is added for parallel event gen.

In addition, this commit has the following changes:

- Small adjustments to seeding of Pythia8 in order
  to avoid same seeds in multiple parallel Pythia instances.

- possibility to init external generator from an INI file (typically
  done or available in O2DPG)

- use shared_ptr instead of unique_ptr to keep generators in order
  to avoid lifetime problems with async processing

- preparion to run underlying generator Init() functions in async way
  (not active yet; needs checks if generators are thread safe)
@sawenzel sawenzel force-pushed the swenzel/hybrid_async branch from 0c1ff2a to 526ae57 Compare December 12, 2024 10:25
@jackal1-66
Copy link
Collaborator

AliceO2Group/O2DPG#1845 updated tool for JSON template creation is proposed here related to these modifications.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 526ae57 at 2024-12-12 12:34:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13788-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:25:32: error: 'tracksQA_000' was not declared in this scope; did you mean 'tracksQA_002'?
/sw/SOURCES/O2Physics/13788-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:59:32: error: 'tracksQA_001' was not declared in this scope; did you mean 'tracksQA_002'?
ninja: build stopped: subcommand failed.

Full log here.

@sawenzel sawenzel merged commit f4d9b9c into AliceO2Group:dev Dec 12, 2024
7 of 10 checks passed
@sawenzel sawenzel deleted the swenzel/hybrid_async branch December 12, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants