Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 给 MessageEvent 类添加用于获取唯一表示符的 get_sender_id method() 方法 #113

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

shenyiw
Copy link
Member

@shenyiw shenyiw commented Mar 20, 2024

BREAKING CHANGE: MessageEvent 的子类要求实现 get_sender_id() 方法

MessageEvent 实现用于获取唯一表示符的 get_sender_id() 方法,并且将 is_same_sender() 方法的默认实现更换为调用 get_sender_id() 方法。

BREAKING CHANGE: MessageEvent 的子类要求实现 get_sender_id() 方法
@shenyiw shenyiw requested a review from st1020 March 20, 2024 12:59
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f4ce37c) to head (23c7518).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          827       829    +2     
=========================================
+ Hits           827       829    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st1020 st1020 merged commit d17b62d into master Mar 20, 2024
25 checks passed
@st1020 st1020 deleted the feat/add-get-sender-id-method-in-message-event branch March 20, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants