Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add list-processing algorithms #28

Merged
merged 33 commits into from
Apr 29, 2024
Merged

Feat: Add list-processing algorithms #28

merged 33 commits into from
Apr 29, 2024

Conversation

tuduun
Copy link
Collaborator

@tuduun tuduun commented Apr 28, 2024

Description

This is a new feature. We added a folder that contains different types of list algorithms.
It includes:

  • basics.py: contains basic list operations like append and pop.
  • combination.py: contains concatenation and other methods of joining lists
  • search.py: contains list searching algorithms
  • sort.py: contains list sorting algorithms
  • other.py: other type of list operations

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please briefly write the names of the added tests to test your functionality.

  • Test A

  • Test B

  • [+] This PR does not need tested

@simojo
Copy link
Collaborator

simojo commented Apr 29, 2024

@tuduun

[gw0] linux -- Python 3.11.6 /_scratch/cs202/bosco/.venv/bin/python

    @pytest.fixture
    def bosco():
        """Return a Bosco instance for use in the tests."""
>       return Bosco(
            Application_Name="bosco",
            Application_Author="BoscoTeam",
            Emoji=":dizzy:",
            Name="bosco",
            Programming_Language="python",
            Separator="/",
            Tagline="bosco: Measure the performance of Python functions!",
            Theme_Background="default",
            Theme_Colors="ansi_dark",
            Website=":link: GitHub: https://github.com/gkapfham/chasten",
        )
E       NameError: name 'Bosco' is not defined

tests/test_constants.py:11: NameError
_________________________________________________ ERROR at setup of test_number_of_constants __________________________________________________
[gw2] linux -- Python 3.11.6 /_scratch/cs202/bosco/.venv/bin/python

    @pytest.fixture
    def bosco():
        """Return a Bosco instance for use in the tests."""
>       return Bosco(
            Application_Name="bosco",
            Application_Author="BoscoTeam",
            Emoji=":dizzy:",
            Name="bosco",
            Programming_Language="python",
            Separator="/",
            Tagline="bosco: Measure the performance of Python functions!",
            Theme_Background="default",
            Theme_Colors="ansi_dark",
            Website=":link: GitHub: https://github.com/gkapfham/chasten",
        )
E       NameError: name 'Bosco' is not defined

tests/test_constants.py:11: NameError
=========================================================== short test summary info ===========================================================
ERROR tests/test_constants.py::test_default_values - NameError: name 'Bosco' is not defined
ERROR tests/test_constants.py::test_number_of_constants - NameError: name 'Bosco' is not defined
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 2 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! xdist.dsession.Interrupted: stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
======================================================== 23 passed, 2 errors in 0.77s =========================================================

Copy link
Collaborator Author

@tuduun tuduun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simojo!

@simojo
Copy link
Collaborator

simojo commented Apr 29, 2024

@PCain02 linting checks don't pass, but that's all. This should be OK to merge.

Copy link
Collaborator

@Barker0103 Barker0103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@simojo simojo requested review from Barker0103 and simojo April 29, 2024 02:01
Copy link
Collaborator

@Barker0103 Barker0103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@PCain02 PCain02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simojo simojo merged commit 69e0da9 into main Apr 29, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants