first pass at benchmarks. need post-processing, formatting, dynamism.… #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… e.g., the job id from slurm is fixed for testing purposes.
jpfairbanks
requested changes
Nov 22, 2024
| @@ -0,0 +1,17 @@ | |||
| # Benchmarks | |||
|
|
|||
There was a problem hiding this comment.
Committed the results rather than stub
| "Benchmarks" => "benchmarks.md" | ||
| #"ASCII Operators" => "ascii.md", | ||
| #"Canonical Models" => "canon.md", | ||
| #"Library Reference" => "api.md" |
There was a problem hiding this comment.
you can use draft mode in Documenter to disable running specific pages.
| end | ||
| end | ||
| end | ||
| end |
| ks = keys(benchmark_data); | ||
| open(file, "r+") do f | ||
| foreach(readlines(file)) do line | ||
| stub = filter(u -> startswith(line, "<!-- BENCHMARK:$u -->"), ks); |
There was a problem hiding this comment.
can't you use a regex to parse out the u instead of looping over the keys(benchmark_data) to do this in O(1) time instead of O(n)?
There was a problem hiding this comment.
regex is something like <!-- BENCHMARK:\([A-z]*\)\w+-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to get Cahn-Hilliard working.