Support SciMLStructure Interface #233
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, performing sensitivity analysis on Decapodes simulations requires edits to generated simulation code.
We should use the SciMLStructure.jl interface.
We cannot use the
MTKParametersstruct which already supports the interface without adding generated code that does manual buffer management.So, this PR adds support for passing parameters as the
NamedTuples that we normally use, wrapping values to mark them as "tunable" or "constant".If the overhead of making
NamedTuples is found to be too high, then we can switch to manually managing our buffers.Relatedly, it is probably more performant to define a
structthat silosTunablesinto their own field,Constantsinto their own field, and so on.