Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace present_to_schema with macro in examples and docs #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jmatsushita
Copy link

Fixes #34

Looking at this test it seems that the way to call present_to_schema is to use the macro @present_to_schema

  • Fixed 2 notebook examples:
    • examples/ml_workflow_demo/ml_demo.ipynb
    • examples/company_demo/concise_demo_ACT.ipynb
  • Fixed README.md

It might be possible to write doc tests and use NBInclude.js to tests the notebooks as well (although that might mean either disabling the integration cell which use Postgres, or setting up a more involved testing suite).

Happy to give it a try here if that's of interest or do it in a subsequent PR.

Cheers,

Jun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method Error in Notebook example
1 participant