Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Usage introduction simplification #378

Draft
wants to merge 8 commits into
base: staging
Choose a base branch
from

Conversation

jashapiro
Copy link
Member

Purpose

This PR is to try out some simplifiedsetup instructions for advanced use examples. The general idea is that if people are clicking on "advanced" then they might not need quite so detailed instructions for the introduction

Issue addressed

Closes #357

Remaining concerns and questions

The main question the reviewers should address is whether these instructions are sufficiently clear for someone who comes in with a bit more knowledge of the material; i.e. someone who has used refine.bio before to download data files and has done at least one R notebook analysis.

Additionally, is there enough of an off-ramp for someone who comes in without the prior knowledge... is there enough detail about where to go for more detailed instructions?

@cansavvy
Copy link
Contributor

cansavvy commented Nov 24, 2020

Would it make more sense to discuss these changes by creating a new template file specifically for advanced topics?

I guess this is a good way to get the conversation started.


<img src="https://github.com/AlexsLemonade/refinebio-examples/raw/40e47f4d3f39283effbd9843a457168061be9680/template/screenshots/download-email.png" width=500>

We are going to use non-quantile normalized data for this analysis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried about deleting this piece in particular. We need them to know whether or not they should download quantile normalized data and where to find that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do cover that on line 40, but it could be made more prominent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think screenshots help. I guess bigger question is just because someone's an "advanced topics" user, can we assume they know how to download data from refine.bio and know the refine.bio options more readily?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I think even advanced topics users will appreciate screenshots. Though I do agree with cutting back on the file path hand holding.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my thought, or they could go to another example to get this information. 🤷🏼

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go to another example to get this information. 🤷🏼

If we think they might do this, then we should probably just keep the screenshots here too. I think screenshots help decrease brain glucose usage for simple things.

@jashapiro
Copy link
Member Author

Would it make more sense to discuss these changes by creating a new template file specifically for advanced topics?

I guess this is a good way to get the conversation started.

That is what #372 is for. We split up making the first example from a general template.

@jashapiro jashapiro marked this pull request as draft November 24, 2020 20:15
@jashapiro
Copy link
Member Author

Converting this to a draft pending incorporation of changes in #379

Other changes will come with merging in data section.
Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple other comments in the meantime.

I still disagree with getting rid of the screenshots. I don't think "advanced users" will be upset by having more screenshots. But perhaps we can ask Deepa to weigh in on a discussion about what different kinds of users might expect or respond.


Clicking this link will most likely send this to your downloads folder on your computer.
Move this `.Rmd` file to where you would like this example and its files to be stored.
To run this example yourself, [download the `.Rmd` for this analysis by clicking this link](https://alexslemonade.github.io/refinebio-examples/03-rnaseq/differential_expression_rnaseq_01_rnaseq.Rmd) and moving the `.Rmd` file to your preferred analysis folder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To run this example yourself, [download the `.Rmd` for this analysis by clicking this link](https://alexslemonade.github.io/refinebio-examples/03-rnaseq/differential_expression_rnaseq_01_rnaseq.Rmd) and moving the `.Rmd` file to your preferred analysis folder.
To run this example yourself, [download the `.Rmd` for this analysis by clicking this link](https://alexslemonade.github.io/refinebio-examples/03-rnaseq/differential_expression_rnaseq_01_rnaseq.Rmd) and move the `.Rmd` file to your preferred analysis folder.


<img src="https://github.com/AlexsLemonade/refinebio-examples/raw/40e47f4d3f39283effbd9843a457168061be9680/template/screenshots/download-email.png" width=500>

We are going to use non-quantile normalized data for this analysis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go to another example to get this information. 🤷🏼

If we think they might do this, then we should probably just keep the screenshots here too. I think screenshots help decrease brain glucose usage for simple things.


# Create the plots folder if it doesn't exist
if (!dir.exists(plots_dir)) {
dir.create(plots_dir)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still will need to create these directories though. (Unless you've put this part somewhere else)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try out new Advanced Usage intro/instructions in the WGCNA example
2 participants