Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add introductory paragraphs to microarray GSEA example, review text for RNA-seq GSEA example #354

Closed
cbethell opened this issue Nov 14, 2020 · 3 comments
Assignees
Labels
before going live Needs to be done before we can "go live" or do testing

Comments

@cbethell
Copy link
Contributor

cbethell commented Nov 14, 2020

Background

Per this related comment on PR #347, the microarray pathway analysis GSEA example notebook will need to be updated to reflect changes made to the introductory paragraph for the pathway analyses examples in once issue #349 is completed.

Problem

Per issue #349 and this comment on #340, the pathway analyses examples do not currently contain background information on how to choose a pathway analysis based on one's question and dataset.

What potential "gotchas" do we know of?

Not aware of any potential "gotchas" at the moment.
However, additional context changes may need to be made throughout the notebook based on what is added in the introductory paragraphs.

What are the recommended next steps?

Once #349 is completed, the introductory paragraph determined there would need to be copied over to the 02-microarray/pathway-analysis_microarray_03_gsea.Rmd notebook, remembering to re-run the Snakefile in order to update the rendered html.

Is there a particular timeframe for this issue?

Once #349 is addressed, this issue should take ~1/2 day to complete.

@cbethell cbethell changed the title Updated analysis example: Microarray Pathway Analysis GSEA Updated analysis example: Microarray Pathway Analysis GSEA introductory paragraphs Nov 14, 2020
@cansavvy cansavvy added the before going live Needs to be done before we can "go live" or do testing label Nov 18, 2020
@jaclyn-taroni jaclyn-taroni self-assigned this Nov 23, 2020
@jaclyn-taroni
Copy link
Member

I noticed the following while taking a look at #397. We have a section header that talks about clusterProfiler's options. That section is about msigdbr.

## Getting familiar with `clusterProfiler`'s options

@jaclyn-taroni
Copy link
Member

The issue with this header is also in the ORA example I spot checked, will file a new issue.

@jaclyn-taroni jaclyn-taroni changed the title Updated analysis example: Microarray Pathway Analysis GSEA introductory paragraphs Add introductory paragraphs to microarray GSEA example, review text for RNA-seq GSEA example Dec 13, 2020
@jaclyn-taroni
Copy link
Member

Closed via #434 and #437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before going live Needs to be done before we can "go live" or do testing
Projects
None yet
Development

No branches or pull requests

3 participants