Configurable separator character to replace ':'. Defaults to '#' #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing this character while save files already exists will break output until the save files are fixed. It is very easy to fix these files: just replace the old separator with the new separator.
AlexisBRENON
requested changes
Jun 7, 2021
Co-authored-by: Alexis BRENON <[email protected]>
AlexisBRENON
requested changes
Jun 15, 2021
| @@ -1,10 +1,14 @@ | |||
| TODO_SAVE_TASKS_FILE="$HOME/.todo.sav" | |||
| TODO_SAVE_COLOR_FILE="$HOME/.todo_color.sav" | |||
|
|
|||
| # Using '#' because its pretty uncommon to type | |||
| # typeset arrays by default use ':' but that means we can't have iTerm2 clickable URLs! | |||
| TODO_SEP="${TODO_SEP:-"\#"}" | |||
There was a problem hiding this comment.
Maybe the default value should still be :, else it will break any existing todo file... Even if I don't know if there is a lot ^^
Suggested change
| TODO_SEP="${TODO_SEP:-"\#"}" | |
| TODO_SEP="${TODO_SEP:-":"}" |
If you have a good argument against the colon, I am open to change the default to #.
But this would be a breaking change and so must be considered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customizable separator. It could have a better user experience instead of having to edit this file, like overwriting a global shall parameter, but this is pretty usable as is.