Option to not wrap MqLayout content in a <div> #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonrya
reviewed
Jul 12, 2019
| }, | ||
| createContainer: { | ||
| type: Boolean, | ||
| default: false |
There was a problem hiding this comment.
Should the default remain true since this could break some CSS? I agree that default should've been false all along, but I wonder if the new option has to lean towards precedence.
There was a problem hiding this comment.
Keep it true, for this pull request. so we do not break something for anyone.
this option is needed anyway. regardless of default-setting.
|
Hi, this is a great improvement, but how do you use it ? |
ghaithar
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by #31.