This repository has been archived by the owner on Oct 19, 2020. It is now read-only.
Android more than 20 inapp purchases with a new iabhelper version #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2016 12:37
…Purchase works after you did 20 or more purchases; Also no more limits for getProducts
meldron
changed the title
NateEag
pushed a commit
to NxtbookMedia/cordova-plugin-inapppurchase
that referenced
this pull request
Apr 5, 2019
The old implementation fails when there are more than twenty products and the user owns some of them. This is ripped shamelessly from this PR that upstream has never accepted: AlexDisler#57 Note that this undoes the conceptually-wrong change that *was* accepted to deal with this problem: AlexDisler#94
NateEag
pushed a commit
to NxtbookMedia/cordova-plugin-inapppurchase
that referenced
this pull request
Apr 5, 2019
The old implementation fails when there are more than twenty products and the user owns some of them. This is ripped shamelessly from this PR that upstream has never accepted: AlexDisler#57 Note that this undoes the conceptually-wrong change that *was* accepted to deal with this problem: AlexDisler#94
NateEag
pushed a commit
to NxtbookMedia/cordova-plugin-inapppurchase
that referenced
this pull request
Apr 5, 2019
The previous implementation fails when there are more than twenty products and the user owns some of them. This is just a copy of this PR that upstream has never accepted: AlexDisler#57 Note that this undoes the conceptually-wrong change that *was* accepted to deal with this problem (but doesn't): AlexDisler#94 I've worked through this patch line-by-line and it seems like a reasonable solution to me. Granted, it's been a few years since I wrote Java, but conceptually it seems right - handle the Google API's demand for chunking internally to the querySkuDetails() method, so nothing else has to know about it.
|
...huh, didn't occur to me that my commit-amending was going to show up on here. Sorry for the noise. That said, can a maintainer explain to me why this was never merged? As the comments in #94 show, the other approach doesn't actually constrain chunks to be less than twenty items, since it ignores what's actually happening in This patch solves the problem I ran into and keeps things conceptually simpler. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is mentioned in the Readme.md
getProductson Android works only for up to 20 product ids, with this commits this issue is fixed.Another unmentioned problem is, that after buying 20 products,
restoreProductsis no longer working. This is also fixed.As base of these fixes
querySkuDetailsof a newer version from OpenIAB has been used.I think a complete update to the newer version of https://github.com/oorlov/OpenIAB should be done.