This repository has been archived by the owner on Oct 19, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent the better part of a day trying to debug an issue the plugin was causing on older android versions (~4.4.4 and below) - the Array.find polyfill works perfectly for what you use it for, but seems to trigger something internal to angular - perhaps it has it's own version of feature detection in which it uses an alternative to Array.find if it's not available in the environment.
The problem that arose was that the rest of my app code (i'm using Ionic framework, dump of my environment below) seemed to be throwing no end of exceptions (thrown by the polyfill itself) when the polyfill was included - removing it obviously fixed the exceptions, but broke the inapppurchase section of the app.
So i noticed you only seemed to be using .find in one small utility, so i swapped it out - i won't be offended if you don't want to merge this - i'll just keep using our forked version, but i thought i'd raise it anyway.
Thanks for the plugin, it's great, best i've found.