Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MegaLinter] Apply linters automatic fixes to #4661 #18

Open
wants to merge 27 commits into
base: dev_bmesons
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5e4b5de
PWGHF: Add D+ -> KKPi flag for MC (#4616)
fchinu Feb 10, 2024
b5960b1
Adapt nucleiFlow to the updated data model (#4650)
lbariogl Feb 10, 2024
7a64542
PWGLF: Add centrality QA/testing mode for der data (#4653)
ddobrigk Feb 10, 2024
01d5ef0
First version of cascadeflow (#4652)
ChiaraDeMartin95 Feb 10, 2024
b0955ff
PWGLF: Update lambda1520SpherocityAnalysis.cxx (#4663)
yashpatley Feb 10, 2024
07d565c
Update r2p2-4-id.cxx (#4658)
R-Rohith Feb 11, 2024
77e7096
PWGCF: flow-pb-pb: modify filter conditions (#4656)
Luzhiyongg Feb 11, 2024
907bd4b
DPG: Fix QA efficiency (#4651)
njacazio Feb 11, 2024
361e431
[PWGCF] First step towards identified analysis (#4667)
victor-gonzalez Feb 11, 2024
8adab00
PWGCF: Debug-task: Add optional THnSparse plots (#4659)
gmantzar Feb 11, 2024
0fc0205
More cuts (#4657)
rbailhac Feb 11, 2024
3693c23
Second step towards identified analysis (#4668)
victor-gonzalez Feb 11, 2024
818483b
PWGLF: adjust TPC conditions in detail (#4664)
ddobrigk Feb 11, 2024
58d413a
PWGLF: extra event info for debug tests (#4662)
ddobrigk Feb 11, 2024
ac57ad5
Update QAHistTask.cxx (#4655)
RafRaf11 Feb 11, 2024
b6b1367
[DGP] AOTTrack - Fix De PID in qaEfficiency (#4654)
giovannimalfattore Feb 11, 2024
bf4411a
Fix particle selection (#4670)
victor-gonzalez Feb 11, 2024
9f2e3e5
PWGEM/PhotonMeson: revert mean ITS cluster size cut (#4671)
dsekihat Feb 12, 2024
61a44cc
[PWGUD] Updating my task (#4613)
rolavick Feb 12, 2024
2eccc12
PWGUD/AQC (#4660)
akhatun Feb 12, 2024
e6381d9
Add configurable axes for THnSparses in TPC PID QC (#4669)
jezwilkinson Feb 12, 2024
ff8da3f
PWGHF: save info isGlobalTrakWoDca for pion (#4672)
ZFederica Feb 12, 2024
c8f6b85
Fix bc() access (#4674)
fmazzasc Feb 12, 2024
4e741fa
Adding possibilty to study D0 reflections. (#4666)
arossi81 Feb 12, 2024
0ad6745
kshort kshort analysis (#4675)
sawankumawat Feb 12, 2024
f3e0ecd
Merge 6e59169f57fb650dd3d1a8e946ef1b42262bd707 into 0ad674501c1027b94…
AlexBigO Feb 12, 2024
0c2f693
MegaLinter fixes
alibuild Feb 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions DPG/Tasks/AOTTrack/PID/qaPIDTPC.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -90,19 +90,23 @@ struct tpcPidQa {
Configurable<float> minP{"minP", 0.01, "Minimum momentum in range"};
Configurable<float> maxP{"maxP", 20, "Maximum momentum in range"};
ConfigurableAxis etaBins{"etaBins", {100, -1.f, 1.f}, "Binning in eta"};
ConfigurableAxis phiBins{"phiBins", {100, 0, TMath::TwoPi()}, "Binning in eta"};
ConfigurableAxis phiBins{"phiBins", {100, 0, TMath::TwoPi()}, "Binning in phi"};
ConfigurableAxis trackLengthBins{"trackLengthBins", {100, 0, 1000.f}, "Binning in track length plot"};
ConfigurableAxis deltaBins{"deltaBins", {200, -1000.f, 1000.f}, "Binning in Delta (dEdx - expected dEdx)"};
ConfigurableAxis expSigmaBins{"expSigmaBins", {200, 0.f, 200.f}, "Binning in expected Sigma"};
ConfigurableAxis nSigmaBins{"nSigmaBins", {401, -10.025f, 10.025f}, "Binning in NSigma"};
ConfigurableAxis dEdxBins{"dEdxBins", {5000, 0.f, 5000.f}, "Binning in dE/dx"};
// Axes for optional THnSparse
ConfigurableAxis binsPForSparse{"binsPForSparse", {200, 0.f, 20.f}, "Binning in momentum for optional THnSparse"};
ConfigurableAxis binsEtaForSparse{"binsEtaForSparse", {50, -1.f, 1.f}, "Binning in eta for optional THnSparse"};
ConfigurableAxis binsnSigmaForSparse{"binsnSigmaForSparse", {101, -7.575, 7.575}, "Binning in nsigma for optional THnSparse"};
Configurable<int> applyEvSel{"applyEvSel", 2, "Flag to apply event selection cut: 0 -> no event selection, 1 -> Run 2 event selection, 2 -> Run 3 event selection"};
Configurable<int> trackSelection{"trackSelection", 1, "Track selection: 0 -> No Cut, 1 -> kGlobalTrack, 2 -> kGlobalTrackWoPtEta, 3 -> kGlobalTrackWoDCA, 4 -> kQualityTracks, 5 -> kInAcceptanceTracks"};
Configurable<bool> applyRapidityCut{"applyRapidityCut", false, "Flag to apply rapidity cut"};
Configurable<bool> splitSignalPerCharge{"splitSignalPerCharge", true, "Split the signal per charge (reduces memory footprint if off)"};
Configurable<bool> enableDeDxPlot{"enableDeDxPlot", true, "Enables the dEdx plot (reduces memory footprint if off)"};
Configurable<int16_t> minTPCNcls{"minTPCNcls", 0, "Minimum number or TPC Clusters for tracks"};
ConfigurableAxis tpcNclsBins{"tpcNclsBins", {16, 0, 160}, "Bining in number of cluster in TPC"};
ConfigurableAxis tpcNclsBins{"tpcNclsBins", {16, 0, 160}, "Binning in number of clusters in TPC"};
Configurable<bool> fillTHnSparses{"fillTHnSparses", false, "Flag to fill multidimensional histograms for nsigma vs pt, eta, Ncls"};

template <o2::track::PID::ID id>
Expand Down Expand Up @@ -185,8 +189,10 @@ struct tpcPidQa {

const AxisSpec etaAxis{etaBins, "#it{#eta}"};
const AxisSpec tpcnclsAxis{tpcNclsBins, "TPC #cls"};

HistogramConfigSpec particleSparseHists{HistType::kTHnSparseF, {pAxis, etaAxis, nSigmaAxis, tpcnclsAxis}};
const AxisSpec sparseMomentumAxis{binsPForSparse, "#it{p} (GeV/#it{c})"};
const AxisSpec sparseEtaAxis{binsEtaForSparse, "#eta"};
const AxisSpec sparseNSigmaAxis{binsnSigmaForSparse, "#n_{#sigma}^{TPC}"};
HistogramConfigSpec particleSparseHists{HistType::kTHnSparseF, {sparseMomentumAxis, sparseEtaAxis, sparseNSigmaAxis, tpcnclsAxis}};
if (fillTHnSparses) {
histos.add(hnsigma_p_eta_Ncl[id].data(), axisTitle, particleSparseHists);
}
Expand All @@ -202,7 +208,7 @@ struct tpcPidQa {
histos.add(hexpsigma_wTOF[id].data(), "With TOF", kTH2F, {pAxis, expSigmaAxis});
histos.add(hnsigma_wTOF[id].data(), Form("With TOF %s", axisTitle), kTH2F, {pAxis, nSigmaAxis});

HistogramConfigSpec particleSparseHists_wTOF{HistType::kTHnSparseF, {pAxis, etaAxis, nSigmaAxis, tpcnclsAxis}};
HistogramConfigSpec particleSparseHists_wTOF{HistType::kTHnSparseF, {sparseMomentumAxis, sparseEtaAxis, sparseNSigmaAxis, tpcnclsAxis}};
if (fillTHnSparses) {
histos.add(hnsigma_p_eta_Ncl_wTOF[id].data(), Form("With TOF %s", axisTitle), particleSparseHists_wTOF);
}
Expand Down
18 changes: 15 additions & 3 deletions DPG/Tasks/AOTTrack/qaEfficiency.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ struct QaEfficiency {
Configurable<bool> noFakesHits{"noFakesHits", false, "Flag to reject tracks that have fake hits"};
Configurable<bool> skipEventsWithoutTPCTracks{"skipEventsWithoutTPCTracks", false, "Flag to reject events that have no tracks reconstructed in the TPC"};
Configurable<float> maxProdRadius{"maxProdRadius", 9999.f, "Maximum production radius of the particle under study"};
Configurable<float> nsigmaTPCDe{"nsigmaTPCDe", 3.f, "Value of the Nsigma TPC cut for deuterons PID"};
// Charge selection
Configurable<bool> doPositivePDG{"doPositivePDG", false, "Flag to fill histograms for positive PDG codes."};
Configurable<bool> doNegativePDG{"doNegativePDG", false, "Flag to fill histograms for negative PDG codes."};
Expand Down Expand Up @@ -820,10 +821,14 @@ struct QaEfficiency {

void initData(const AxisSpec& axisSel)
{
if (!doprocessData) {
if (!doprocessData && !doprocessDataWithPID) {
return;
}

if (doprocessData == true && doprocessDataWithPID == true) {
LOG(fatal) << "Can't enable processData and doprocessDataWithPID in the same time, pick one!";
}

auto h = histos.add<TH1>("Data/trackSelection", "Track Selection", kTH1F, {axisSel});
h->GetXaxis()->SetBinLabel(trkCutIdxTrkRead, "Tracks read");
h->GetXaxis()->SetBinLabel(trkCutIdxHasMcPart, "");
Expand Down Expand Up @@ -1640,18 +1645,25 @@ struct QaEfficiency {
switch (globalTrackSelection) {
case 0:
isTrackSelectedAfteAll = true;
break;
case 1:
isTrackSelectedAfteAll = track.isGlobalTrack();
break;
case 2:
isTrackSelectedAfteAll = track.isGlobalTrackWoPtEta();
break;
case 3:
isTrackSelectedAfteAll = track.isGlobalTrackWoDCA();
break;
case 4:
isTrackSelectedAfteAll = track.isQualityTrack();
break;
case 5:
isTrackSelectedAfteAll = track.isInAcceptanceTrack();
break;
case 6:
isTrackSelectedAfteAll = customTrackCuts.IsSelected(track);
break;
default:
LOG(fatal) << "Can't interpret track asked selection " << globalTrackSelection;
}
Expand Down Expand Up @@ -1925,7 +1937,7 @@ struct QaEfficiency {
if (!isTrackSelected<false>(track, HIST("Data/trackSelection"))) {
continue;
}
if (abs(track.tpcNSigmaDe()) > 3.f) {
if (abs(track.tpcNSigmaDe()) > nsigmaTPCDe) {
continue;
}
histos.fill(HIST("Data/trackLength"), track.length());
Expand Down Expand Up @@ -2036,7 +2048,7 @@ struct QaEfficiency {
}
}
}
PROCESS_SWITCH(QaEfficiency, processHmpid, "process HMPID matching", true);
PROCESS_SWITCH(QaEfficiency, processHmpid, "process HMPID matching", false);
};

WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
Expand Down
Loading
Loading