fix(apostrophe): fixes issue with apostrophe breaking config (Canadia…

…n-Geospatial-Platform#2681)
Alex-NRCan · Jan 10, 2025 · 7606951 · 7606951
1 parent af5b3d4
commit 7606951
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/geoview-core/public/templates/demos/demo-osdp-integration.html b/packages/geoview-core/public/templates/demos/demo-osdp-integration.html
@@ -93,7 +93,7 @@ <h4 id="HMap1">OSDP Integration</h4>
                 return new Promise (resolve => {
                   removeMap('Map1')
                     .then(() => {
-                      cgpv.api.createMapFromConfig('Map1', JSON.stringify(mapConfig).replace(/'/g, "\\'"), 800)
+                      cgpv.api.createMapFromConfig('Map1', JSON.stringify(mapConfig), 800)
                       .then(() => {
                           resolve();
                         });

diff --git a/packages/geoview-core/src/app.tsx b/packages/geoview-core/src/app.tsx
@@ -189,7 +189,7 @@ export async function initMapDivFromFunctionCall(mapDiv: HTMLElement, mapConfig:
     // Create a data-config attribute and set config value on the div
     const att = document.createAttribute(url ? 'data-config-url' : 'data-config');
     // Clean apostrophes in the config
-    att.value = JSON.stringify(mapConfig).replace(/'/g, "\\'");
+    att.value = mapConfig.replaceAll("'", "\\'");
     mapDiv.setAttributeNode(att);
 
     // Set the geoview-map class on the div so that this class name is standard for all maps (either created via init or via func call)