Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emoji codepoints to JoyPixels v6.6.0 #1257

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

zanechua
Copy link
Contributor

@zanechua zanechua commented Oct 4, 2021

No description provided.

@zanechua
Copy link
Contributor Author

zanechua commented Oct 4, 2021

Would be savvy if we could get this labeled as hacktoberfest-accepted

Copy link
Contributor

@Grafikart Grafikart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain more the intent of this change. Thanks ;)

@zanechua
Copy link
Contributor Author

zanechua commented Oct 4, 2021

@Grafikart

Are you maintaining this repo instead of Alex now?

Details here: #827

Basically this updates the codepoints for emoji's so we'll get access to newer emojis in the emoji plugin.

No one else seems to be maintaining the codepoints and since I was the one who made the initial change, it's kinda my baby at this point.

@Alex-D Alex-D merged commit b89d846 into Alex-D:develop Oct 4, 2021
@Alex-D
Copy link
Owner

Alex-D commented Oct 4, 2021

Thank you :)

As a side note: everyone is free to review the code, so if @Grafikart wanted to review it, he can :) And I understand that a PR without any message can be hard to review.

Also, I've read the hacktoberfest things, it seems that merging works the same as the label. I do not want to create labels dedicated to hacktoberfest since it makes no sens other months ^^

@zanechua
Copy link
Contributor Author

zanechua commented Oct 5, 2021

Oh that's neat. :)

Sure, no qualms about that. Thanks @Alex-D and @Grafikart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants