Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Radio Component in ClassificationModal #1786

Open
wants to merge 3 commits into
base: stage
Choose a base branch
from

Conversation

lucaslobatob
Copy link
Collaborator

Description

ClassificationModal.tsx: Replace Antd Radio component with MUI Radio in ClassificationModal, add FormControlLabel to integrate custom labels (ClassificationText) with radio buttons, following MUI best practices.

Fixes #1584

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Existing feature enhancement (non-breaking change which modifies existing functionality)

Testing

1. Be on mobile;
2. Log in to the platform;
3. Create a affirmation or open a existent;
4. Select the part of the affirmation you want to review;
5. Fill out the form;
6. Click in "Selecione uma Classificação" Select;
7. Click on the Radio to rate the sentence.

Before:
Screenshot from 2025-01-20 11-46-47

After:
Screenshot from 2025-01-20 11-55-13

Developer Checklist

General

  • Code is appropriately commented, particularly in hard-to-understand areas
  • Repository documentation has been updated (Readme.md) with additional steps required for a local environment setup.
  • No console.log or related logging is added.
  • No code is repeated/duplicated in violation of DRY. The exception to this is for new (MVP/Prototype) functionality where the abstraction layer may not be clear (comments should be added to explain the violation of DRY in these scenarios).
  • Documented with TSDoc all library and controller new functions

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in JIRA issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

@thesocialdev
Copy link
Collaborator

@lucaslobatob I believe you're in the right track, but the visual differences are quite perceptive, can you take another pass and fix those? Especially the font difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Migrate component ClassificationModal.tsx - Import { Radio }
2 participants