Adapting imports of {Row} alone and { Row, Col } together to Grid/mui #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thesocialdev
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I addressed all the issues created during the switch from Ant to MUI that involved importing only { Row } and { Row, Col } together. I adapted them to use { Grid } from MUI without losing the standard layout. This way, we can resolve issues that require similar and/or minor changes.
Testing
You should go to each component where the switch from Ant to MUI was made and test the design and responsiveness. In this case, since it involves replacing a component that handles columns, you only need to ensure that nothing is broken or out of place.
Each components:
A visual document outlining which visual parts of the site are intended to facilitate testing:
...
testing geral responsividade.pdf
OBS:
I was unable to test Copilotconversation.style.tsx. I think it's unlikely that it broke, but I did it blindly.