Merge pull request #1074 from AletheiaFact/hotfix-user-creation

Hotfix: Fixed User creation
AletheiaFact · Oct 31, 2023 · 5d7e005 · 5d7e005
2 parents 2e2c40b + 820f571
commit 5d7e005
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/server/auth/ory/ory.service.ts b/server/auth/ory/ory.service.ts
@@ -93,7 +93,7 @@ export default class OryService {
             url,
             schema_id,
         } = this.configService.get("ory");
-        return fetch(`${url}/${this.adminEndpoint}/identities`, {
+        const result = await fetch(`${url}/${this.adminEndpoint}/identities`, {
             method: "post",
             body: JSON.stringify({
                 schema_id,
@@ -113,6 +113,8 @@ export default class OryService {
                 Authorization: `Bearer ${token}`,
             },
         });
+
+        return await result.json();
     }
 
     deleteIdentity(identityId): Promise<any> {

diff --git a/server/users/schemas/user.schema.ts b/server/users/schemas/user.schema.ts
@@ -1,5 +1,5 @@
 import { Prop, Schema, SchemaFactory } from "@nestjs/mongoose";
-import { Status } from "../../auth/ability/ability.factory";
+import { Roles, Status } from "../../auth/ability/ability.factory";
 import { Document, Types } from "mongoose";
 import { Badge } from "../../badge/schemas/badge.schema";
 
@@ -21,7 +21,7 @@ export class User {
     @Prop({ required: true, default: false })
     firstPasswordChanged: boolean;
 
-    @Prop({ type: Object, required: true })
+    @Prop({ type: Object, required: true, default: { main: Roles.Regular } })
     role: object;
 
     @Prop({ required: true, default: false })

diff --git a/server/users/users.service.ts b/server/users/users.service.ts
@@ -52,7 +52,7 @@ export class UsersService {
         this.notificationService.createSubscriber(newUser);
         if (!newUser.oryId) {
             this.logger.log("No user id provided, creating a new ory identity");
-            const { data: oryUser } = await this.oryService.createIdentity(
+            const oryUser = await this.oryService.createIdentity(
                 newUser,
                 user.password,
                 user.role