Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show latency and token count in benchmark execution detail view #1185

Merged
merged 4 commits into from
Dec 18, 2024
Merged

feat: show latency and token count in benchmark execution detail view #1185

merged 4 commits into from
Dec 18, 2024

Conversation

NiklasKoehneckeAA
Copy link
Contributor

@NiklasKoehneckeAA NiklasKoehneckeAA commented Dec 17, 2024 •
edited by MerlinKallenbornAA
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@MerlinKallenbornAA MerlinKallenbornAA marked this pull request as ready for review December 18, 2024 16:21
@MerlinKallenbornAA MerlinKallenbornAA force-pushed the PHS-895-show-latency-and-token-count-in-benchmark-execution-detail-view branch from 81485db to a4c38bd Compare December 18, 2024 16:27
@NiklasKoehneckeAA NiklasKoehneckeAA force-pushed the PHS-895-show-latency-and-token-count-in-benchmark-execution-detail-view branch from a4c38bd to 519f402 Compare December 18, 2024 16:31
@NiklasKoehneckeAA NiklasKoehneckeAA merged commit b4212d2 into main Dec 18, 2024
4 checks passed
@NiklasKoehneckeAA NiklasKoehneckeAA deleted the PHS-895-show-latency-and-token-count-in-benchmark-execution-detail-view branch December 18, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinKallenbornAA MerlinKallenbornAA MerlinKallenbornAA left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiklasKoehneckeAA @MerlinKallenbornAA