feat: Upload dataset from il sdk #1116
Conversation
MerlinKallenbornAA
changed the title
MerlinKallenbornAA
force-pushed
the
PHS-842-upload-dataset-from-il-sdk
branch
from
cbbb5a3
to
adc2e68
Compare
MerlinKallenbornAA
force-pushed
the
PHS-842-upload-dataset-from-il-sdk
branch
from
adc2e68
to
c934a18
Compare
| Dataset, | ||
| Example, | ||
| ExpectedOutput, | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
We should add a block comment somewhere that this is not exported to connectors.XXX. Maybe it would even be better to not export the StudioDataRepository to eval but rather export this to connectors
| dataset: :Dataset: to be uploaded | ||
| examples: :Examples: of Dataset |
There was a problem hiding this comment.
where did you get this docstring? i feel like we always did this via ... instead of :...:
There was a problem hiding this comment.
Fair, had it mixed up. Corrected it
There was a problem hiding this comment.
with backticks i mean
| _status_code_to_exception: ClassVar[dict[int, type[DataError]]] = { | ||
| HTTPStatus.SERVICE_UNAVAILABLE: DataExternalServiceUnavailable, | ||
| HTTPStatus.NOT_FOUND: DataResourceNotFound, | ||
| HTTPStatus.UNPROCESSABLE_ENTITY: DataInvalidInput, | ||
| HTTPStatus.FORBIDDEN: DataForbiddenError, | ||
| } |
There was a problem hiding this comment.
I don't quite see the reason to make these our own errors
| @fixture | ||
| def examples() -> Sequence[Example[str, str]]: | ||
| return [ | ||
| Example(input="input_str", expected_output="output_str"), | ||
| Example(input="input_str2", expected_output="output_str2"), | ||
| ] |
There was a problem hiding this comment.
have you checked if we have this fixture already? otherwise not a big deal to redefine it if it does not fit
There was a problem hiding this comment.
Yes, but in the "wrong" conftest.
| ) | ||
| result = studio_client.submit_dataset(dataset=dataset, examples=examples) | ||
|
|
||
| assert result is not None |
There was a problem hiding this comment.
we could check that the dataset we get back has the metadata / labels etc that we expect
There was a problem hiding this comment.
Added an "has been called with" assertion type
Description
PHS-842
Before Merging
changelog.mdif necessary