Drop default api url for host of clients #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -217,7 +210,7 @@ def test_explanation_with_token_granularities_oom_regression(sync_client: Client | |||
|
|
|||
| ### Response:""" | |||
| target_text = " India won the Battle of Waterloo." | |||
| model_name = "luminous-base-control" | |||
| model_name = "luminous-base" | |||
There was a problem hiding this comment.
Why move away from control?
There was a problem hiding this comment.
as it is (currently at least) not available in our new environment
docs/source/index.rst
Outdated
| @@ -18,7 +18,7 @@ Synchronous client. | |||
| from aleph_alpha_client import Client, CompletionRequest, Prompt | |||
| import os | |||
|
|
|||
| client = Client(token=os.getenv("AA_TOKEN")) | |||
| client = Client(token=os.getenv("AA_TOKEN"), host="https://inference-api.your-domain.com") | |||
There was a problem hiding this comment.
Why not get the host from the .env, too?
There was a problem hiding this comment.
good catch. Probably the better approach, will update.
WieslerAA
reviewed
Dec 5, 2024
| @@ -24,7 +24,7 @@ jobs: | |||
| poetry run mypy tests --ignore-missing-imports | |||
| - name: Run tests | |||
| run: | | |||
| poetry run pytest | |||
| poetry run pytest --color=yes | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.