-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4 - #6 - #9 - #10 - kebab, sauce and filling crud, kebab data #14
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # app/Models/Filling.php # app/Models/Sauce.php # database/seeders/DatabaseSeeder.php # readme.md
As far as I see there are changes that need attention on frontend, thus will be addressed in AleksandraKozubal/KULA-Mobile#4 |
{ | ||
public function execute(int $fillingId): void | ||
{ | ||
Kebab::query()->whereJsonContains("fillings", $fillingId)->get() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kebab? Shouldn't it be KebabPlace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to merge branch with kebab data seeders here bc some errors were fixed there and I thought that's better way to do it now
To run real data seeders just run php artisan migrate:fresh --seed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data is inconsistent:
example for social medias:
Sphinx
{ "id": 31, "name": "KEBAB Sphinx", "image": "kebab-place/sphinx-kebab.jpg", "address": "Najświętszej Marii Panny", "latitude": "51.209281018102246", "longitude": "16.16491389168841", "google_maps_url": null, "google_maps_rating": null, "phone": "574 179 918", "website": null, "android": null, "ios": null, "email": null, "opened_at_year": null, "closed_at_year": 2020, "opening_hours": [], "fillings": [], "sauces": [], "status": "zamknięte", "is_craft": false, "is_chain_restaurant": true, "location_type": "lokal", "order_options": [], "social_media": { "name": "fb", "url": "https://www.facebook.com/people/Kebab-Sphinx-Legnica/100064028922914/" }, "created_at": "2025-01-13T22:11:57.000000Z", "updated_at": "2025-01-13T22:11:57.000000Z" },and other:
Empire
{ "id": 26, "name": "Kebab Empire", "image": "kebab-place/kebab-empire.jpg", "address": "Fabryczna 13", "latitude": "51.20677303064106", "longitude": "16.17869613057113", "google_maps_url": "https://maps.app.goo.gl/X7hFNX8eWv5KnMn1A", "google_maps_rating": null, "phone": "573 683 905", "website": null, "android": null, "ios": null, "email": "[email protected]", "opened_at_year": null, "closed_at_year": null, "opening_hours": [], "fillings": [ 3, 4, 5, 6 ], "sauces": [ 3, 5, 6, 7 ], "status": "zamknięte", "is_craft": false, "is_chain_restaurant": false, "location_type": "lokal", "order_options": [], "social_media": [ { "name": "fb", "url": "https://www.facebook.com/p/Kebab-Empire-Legnica-100086383969163/" } ], "created_at": "2025-01-13T22:11:57.000000Z", "updated_at": "2025-01-13T22:11:57.000000Z" },other example:
Rulo
{ "id": 22, "name": "Rulo Kebab", "image": "kebab-place/rulo-kebab.jpg", "address": "Nowy Świat", "latitude": "51.205128470632545", "longitude": "16.1545378995454", "google_maps_url": "https://maps.app.goo.gl/QHozQGXuoWRrd7US7", "google_maps_rating": null, "phone": "669 721 401", "website": null, "android": null, "ios": null, "email": null, "opened_at_year": null, "closed_at_year": null, "opening_hours": [], "fillings": [], "sauces": [], "status": "zamknięte", "is_craft": false, "is_chain_restaurant": false, "location_type": "buda", "order_options": [], "social_media": [ { "fb": "https://www.facebook.com/RuloKebab/?locale=pl_PL" } ], "created_at": "2025-01-13T22:11:57.000000Z", "updated_at": "2025-01-13T22:11:57.000000Z" },As far as I know we went for Map type of data:
{
"name": "fb",
"url": "https://www.facebook.com/p/Kebab-Empire-Legnica-100086383969163/"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think we should have Dodatki instead of Mięsa. It will look better with vegetarian fillings.
In this case we want to have json array, not single json, fixed sphinx |
There is no right word for this category, imo Dodatki means all other ingredients. Switched to "Główne składniki" as a compromise word |
"Główne składniki" is okayish, but in mobile app we have "Nadzienia" that could also fit our scenario. We could unify that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data is OK now, I may be worried about many null data occuring, but for mobile app it's fine.
It should close #6, close #9, close #10.
In this pr I:
and provided some cosmetic changes