Fix loading custom properties into Tinymce skin #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3071 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 236 236
Lines 6337 6337
=======================================
Hits 6121 6121
Misses 216 216 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
For the Tinymce skin we need our custom properties available. We cannot simply compile them into the skin, because it gets loaded from Tinymce into the current document and this would lead to duplicated custom properties. So instead we compile it as separate file and include it in the Alchemy admin as first stylesheet. This has the additional advantage that we can load this file into ie. Solidus to display the Alchemy Tinymce skin as well.
tvdeyen
force-pushed
the
importable-custom-properties
branch
from
7114918
to
3987aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3070 but for
mainbranch.For the Tinymce skin we need our custom properties available. We cannot simply compile them into the skin, because it gets loaded from Tinymce into the current document and this would lead to duplicated custom properties.
So instead we compile it as separate file and include it in the Alchemy admin as first stylesheet. This has the additional advantage that we can load this file into ie. Solidus to display the Alchemy Tinymce skin as well.