Add turbo frame support to dialog #2958
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2958 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 236 236
Lines 6331 6332 +1
=======================================
+ Hits 6118 6119 +1
Misses 213 213 ☔ View full report in Codecov by Sentry. |
tvdeyen
force-pushed
the
add-turbo-frame-support-to-dialog
branch
from
04e08b5
to
4cd9333
Compare
tvdeyen
force-pushed
the
add-turbo-frame-support-to-dialog
branch
2 times, most recently
from
ff72e64
to
80641ad
Compare
Handle Turbo related events to support `turbo_frame_tag`s in Dialogs. Follows redirects after successful form submission, if we use `do_redirect_to` which is called by `render_errors_or_redirect`.
We want to be able to test validation responses on resource forms
And turn of remote in order to stop using rails-ujs
tvdeyen
force-pushed
the
add-turbo-frame-support-to-dialog
branch
from
80641ad
to
358bf3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Handle Turbo related events to support
turbo_frame_tagsin Dialogs. Follows redirects after successful form submission,
if we use
do_redirect_towhich is called byrender_errors_or_redirect.Checklist