Remove navigation deep link to promotions #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current Solidus `main` branch, the `Spree::Admin::PromotionsController` does not exist anymore if one only requires `solidus_core` and `solidus_backend`. It's only present if one requires the full `solidus` suite with the `solidus_legacy_promotions` gem. There's also the new `solidus_promotions` gem, and now the path to configuring the promotion system depends on the gem being used. By the time we run this code, the promotion system configuration is probably not loaded. Given that we don't do anything with promotions in this gem, let's remove the deep link. Customers can still get at the promotions admin via the navigation in Solidus.
`main` is by definition unstable, let's not test it.
tvdeyen
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current Solidus
mainbranch, theSpree::Admin::PromotionsControllerdoes not exist anymore if one only requiressolidus_coreandsolidus_backend. It's only present if one requires the fullsolidussuite with thesolidus_legacy_promotionsgem.There's also the new
solidus_promotionsgem, and now the path to configuring the promotion system depends on the gem being used. By the time we run this code, the promotion system configuration is probably not loaded. Given that we don't do anything with promotions in this gem, let's remove the deep link. Customers can still get at the promotions admin via the navigation in Solidus.