Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve etag generation #80

Merged
merged 1 commit into from
May 15, 2024
Merged

Improve etag generation #80

merged 1 commit into from
May 15, 2024

Commits on May 15, 2024

  1. Rely on improved etag for caching 

    The Last-Modified header is a weaker cache key than the etag, and thus
we rely solely on the etag from now on. Browsers and Rails will ignore
it if it's not set while validating if a request is fresh.

Also sets the etag based on JSONAPI's typical set of params, so that we
get a different etag for different `include`, `sort`, `page`, `fields`,
or `filter` params.
    @mamhoff
    mamhoff committed May 15, 2024
    Configuration menu
    Copy the full SHA
    230fdea View commit details
    Browse the repository at this point in the history