fix(graphql): migration to ktor v3

[AngeloFilaseta]

EmbeddedServer now encapsulates ApplicationEngine instead of being a subclass.

Sorry for the other PR, it defaulted to master and I didn't notice.

[DanySK]

@AngeloFilaseta, you can target master directly. Renovate will auto-close its PR once this one is merged.

[AngeloFilaseta]

K, I'll fix it

[mergify]

Hi @AngeloFilaseta! 👋
This pull request has conflicts 😖
Could you fix it? 🔧
Thank you! 🙏

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[AngeloFilaseta]

@DanySK I discovered the cause of the issue (the timeout). It is not caused by ktor itself. I already changed the code following the migration guide and everything should work within Alchemist. The problem is with another dependency graphql-kotlin, which is still not ready to include ktor v3.
For now, the GraphQL server silently fails with java.lang.NoClassDefFoundError: io/ktor/server/routing/RoutingKt since it probably expect to find ktor 2 at runtime, but some package structure changed.
Probably, once this PR gets included in the new version of the library, everything will work as expected.

So... We wait or what?

[DanySK]

Well, I'd say we wait. Set a timer, and let's check back in a month.

[AngeloFilaseta]

There are new developments. The graphql-kotlin project now supports Kotlin 2.
Now this is the PR that needs to be merged. Once they fix it, I'll try to integrate the new version in Alchemist.

[DanySK]

you forgot the link :)

[AngeloFilaseta]

Fixed, I should put 1 euro in the virtual wallet for what I thought

[mergify]

Hi @AngeloFilaseta! 👋
This pull request has conflicts 😖
Could you fix it? 🔧
Thank you! 🙏

[AngeloFilaseta]

Still no solution here, however something is moving, seems like they have a passing CI for KTOR 3.0.3
But it still need to be merged.

[DanySK]

Good! Maybe meanwhile fix the conflicts, so that we don't need to fix a lot of stuff when the fix gets out...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (49d745c) to head (786ed24).
Report is 3 commits behind head on master.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #3844   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines          90      90           
  Branches        3       3           
======================================
  Misses         90      90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud