Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve lint pr title #9

Closed
wants to merge 1 commit into from
Closed

improve lint pr title #9

wants to merge 1 commit into from

Conversation

AlbertHernandez
Copy link
Owner

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@AlbertHernandez AlbertHernandez changed the title ci: improve lint pr title improve lint pr title Jan 6, 2024
Copy link
Contributor

github-actions bot commented Jan 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 5/5
🟢 Branches 100% 0/0
🟢 Functions 100% 1/1
🟢 Lines 100% 4/4

Test suite run success

3 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 20059dc

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Size Change: 0 B

Total Size: 742 B

ℹ️ View Unchanged
Filename Size
dist/index.js 279 B
dist/is-positive-number/index.js 279 B
dist/is-positive-number/is-positive-number.js 184 B

compressed-size-action

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Hey mate 👋. Thank you for opening this Pull Request 🤘. It is really awesome to see this contribution 🚀

🔎 When working with this project we are requesting to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted 🥶.

👇 Bellow you can find details about what failed:

No release type found in pull request title "improve lint pr title". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@AlbertHernandez AlbertHernandez deleted the lint-pr-title branch January 7, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant