Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to node 22 and remove support to 18 #418

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

AlbertHernandez
Copy link
Owner

@AlbertHernandez AlbertHernandez commented Nov 3, 2024

Proposed changes

In this PR we are upgrading to node 22 lts and removing support for node 18

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added 📝 Documentation Improvements or additions to documentation 📦 Dependencies Pull requests that update a dependency file ⚙️ Configuration Indicates the scope is related to the configuration 🚀 CI/CD Indicates the change is related to CI/CD workflows 🐳 Build Indicates the change is related to the build labels Nov 3, 2024
@github-actions github-actions bot added ⚠️ Breaking Change Breaking change in the PR 🚀 Feature Feature added in the PR labels Nov 3, 2024
Copy link
Contributor

github-actions bot commented Nov 3, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@rollup/rollup-linux-x64-gnu 4.24.3 🟢 6
Details
CheckScoreReason
Code-Review⚠️ 2Found 5/19 approved changesets -- score normalized to 2
Maintained🟢 1030 commit(s) and 9 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Packaging⚠️ -1packaging workflow not detected
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 2dependency not pinned by hash detected -- score normalized to 2
Fuzzing⚠️ 0project is not fuzzed
Vulnerabilities🟢 100 existing vulnerabilities detected
npm/@swc/core-linux-x64-gnu 1.7.42 🟢 4.8
Details
CheckScoreReason
Code-Review🟢 4Found 14/29 approved changesets -- score normalized to 4
Maintained🟢 1030 commit(s) and 15 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
Security-Policy⚠️ 0security policy file not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Packaging🟢 10packaging workflow detected
Fuzzing🟢 10project is fuzzed
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Vulnerabilities⚠️ 049 existing vulnerabilities detected
npm/@types/node 22.8.7 🟢 6.9
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 3 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 8Found 25/30 approved changesets -- score normalized to 8
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 9license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Signed-Releases⚠️ -1no releases found
Packaging⚠️ -1packaging workflow not detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Security-Policy🟢 10security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Fuzzing⚠️ 0project is not fuzzed
npm/undici-types 6.19.8 🟢 8.2
Details
CheckScoreReason
Binary-Artifacts🟢 8binaries present in source code
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
CI-Tests🟢 1028 out of 28 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Code-Review🟢 9Found 26/28 approved changesets -- score normalized to 9
Contributors🟢 10project has 90 contributing companies or organizations
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing🟢 10project is fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) and 25 issue activity found in the last 90 days -- score normalized to 10
Packaging🟢 10packaging workflow detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
SAST🟢 10SAST tool is run on all commits
Security-Policy🟢 9security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Vulnerabilities🟢 100 existing vulnerabilities detected
npm/@types/node ^22.8.7 🟢 6.9
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 3 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 8Found 25/30 approved changesets -- score normalized to 8
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 9license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Signed-Releases⚠️ -1no releases found
Packaging⚠️ -1packaging workflow not detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Security-Policy🟢 10security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Fuzzing⚠️ 0project is not fuzzed

Scanned Files

  • package-lock.json
  • package.json

@github-actions github-actions bot added the 🥳 size/s Pull request size S label Nov 3, 2024
Copy link
Contributor

github-actions bot commented Nov 3, 2024

📦 Package Metrics 📦

  • Size of the Package in the base (main): 9.8kB
  • Size of the Package in this branch (deps/upgrade-to-node-22): 9.9kB

@AlbertHernandez AlbertHernandez merged commit 5c82b6e into main Nov 3, 2024
24 checks passed
@AlbertHernandez AlbertHernandez deleted the deps/upgrade-to-node-22 branch November 3, 2024 10:32
@github-actions github-actions bot added ⚠️ Breaking Change Breaking change in the PR 🚀 Feature Feature added in the PR and removed 🚀 Feature Feature added in the PR ⚠️ Breaking Change Breaking change in the PR labels Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Breaking Change Breaking change in the PR 🐳 Build Indicates the change is related to the build 🚀 CI/CD Indicates the change is related to CI/CD workflows ⚙️ Configuration Indicates the scope is related to the configuration 📦 Dependencies Pull requests that update a dependency file 📝 Documentation Improvements or additions to documentation 🚀 Feature Feature added in the PR 🥳 size/s Pull request size S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant