Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB05 Improvement of the visibility of the progress box in budgets component #3

Merged
merged 21 commits into from
May 25, 2021

Conversation

verarojman
Copy link

@verarojman verarojman commented May 20, 2021

Implements AjuntamentdeBarcelona/decidim-barcelona#361
Supersedes #2

Tasks

  • As a visitor I can see the progress box anchored and visible from the Budgets index page
  • As a visitor I can see the progress box anchored and visible from the Budgets detail page
  • As a visitor,
    Given that I close the anchored progress box,
    Then it is displayed in its normal position
  • As an admin,
    Given that I enabled the voting rule by projects,
    Then the number of selected projects is displayed in the progress box instead of the percentage of the total amount.

Additional comments

  • Focus mode removes card margin, padding and borders and reduces its content's font-size by 80%
  • Same focus mode content for project detail and list view
  • No GUI element to enter focus mode again since it opens on page load

Specs

  • Focus mode
  • Order progress shows project count when minimum projects rule is active

Additional work

  • Disable focus mode for mobile (< 800px wide)
  • Hide title and process nav
  • Cookies warning: How to show combined with focus mode?
  • "Flash" messages: How to show combined with focus mode?
  • Omnipresent banner: How to show combined with focus mode?
  • Fit project amount in mobile
  • Al progress box del llistat de projectes eliminaria aquest text que a més està duplicat amb les regles de votació (sobretot per guanyar una mica d'espai i pq no surt tampoc a la vista de detall). I afegiria la negreta a les regles de votació
  • a la vista de detall no queda molt visible com tornar al llistat de projectes d'aquell pressupost. Preveient la gent que entrarà per aquí i que encara haurà de seleccionar 1 altre per poder votar,
    substituiria l'enllaç a la landing per l'enllaç a la llista de projectes, afegiria la negreta a les regles de votació i inclouria el districte al qual pertany aquell projecte
  • Fix progress text in mobile

📷 Screenshots

Focus mode

♥️ Thank you!

@verarojman verarojman merged commit 4231961 into feature/bcn-budget-v0.24 May 25, 2021
microstudi pushed a commit that referenced this pull request May 5, 2022
* allowing only lowercase in the nickname

* nickname test system

* add in locales the "lowercase" precision

* changing routing for timeline

* changing routing for activities

* changing routing for other profile tabs

* migration to change commune nicknames

* linter

* minor changes
increase performance for migration

* Refactor migration for lisibility

* add fix into changelog

* linter

* Update CHANGELOG.md

* add notification when updating nickname

* fix number of notification

* Add notification when updating nickname (#3)

add spec for event
add translation for notification
normalize locales
add logger
refactor
add random numbers to prevent errors

* update message in notification

* update test
linter

* minor changes

* Change requests nickname (#8)

* back to "any case" nickname

* check uniqueness case insensitivity

* change profiles url

* mention, parse case insensitively

* mention, render nicknames case insensitively

* mentions spec

* update migration

* linter

* migration to rake tasks
spec rake task

* linter

* add test notification
fix test nickname

* linter

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update CHANGELOG.md

* Update account_form.rb

* linter

* remove the if statement
private fonctions

* remove test task

* relaunch tests

* add organization criteria
refactors

* lint

* use nicknamize instead of random numbers

* add the not deleted scope

* update nicknamizable to check for case

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants