Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 public bucket configuration #582

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

fblupi
Copy link
Contributor

@fblupi fblupi commented Nov 21, 2024

🎩 What? Why?

The previous configuration was not working as expected as it returned true every time an environment variable AWS_PUBLIC existed, ignoring its value.

This configuration will only include the line public: true in the s3 storage configuration if the environment variable exists and the value is different than 0, false, or no.

📌 Related Issues

@fblupi fblupi added the bug label Nov 21, 2024
@fblupi fblupi requested a review from davidbeig November 21, 2024 16:38
Copy link
Contributor

@davidbeig davidbeig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@davidbeig davidbeig merged commit 4c84055 into master Nov 21, 2024
5 checks passed
@fblupi fblupi deleted the fix/public-s3-config branch November 22, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants