Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and mark servers that enforce but prevent chat reports #437

Open
Madis0 opened this issue Sep 27, 2023 · 5 comments
Open

Detect and mark servers that enforce but prevent chat reports #437

Madis0 opened this issue Sep 27, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request low priority

Comments

@Madis0
Copy link
Collaborator

Madis0 commented Sep 27, 2023

Idea

In 1.20.2, the server-side toast removal was done. We discussed this and it seemed like a sensible thing to do.

However, as a result there may now be servers that both enforce chat signing at the server level and prevent chat signing at chat conversion level. NCR should account for this and show the proper indicator/tooltips by that.

Reasoning

Described above

Other Information

It probably needs new tooltips, but I'm not sure if it needs a new icon - could reuse the yellow one.
The reliability of such indicator is also a bit questionable, but I still think it is possible:

  • Check the type of global/private messages after player presses enter
  • Check if own/others chat is reportable (any messages in the reportable list)

Edit: I forgot the part where NCR announces the green state, in this case - if the two heuristics are met - the state can be shown as green.

Related to #177 but it is more theoretically described there

@Madis0 Madis0 added the enhancement New feature or request label Sep 27, 2023
@Madis0
Copy link
Collaborator Author

Madis0 commented Sep 27, 2023

Well, right now this can't be done with NCR as it will force enforce-secure-profile off, even if it's not disabled in server properties
But it's a thing
The main problem with a setup like this is that the client has to trust the server that signatures are stripped, and not, say, stored by the server or only relayed to specific players

  • Aizistral

So maybe reusing green or yellow is not the best idea...
It is still an unique state to indicate and arguably less dangerous than the normal enforced signature state. But because the client essentially loses control and only sees what the server tells, it is a matter of trust.

@Secret-chest
Copy link
Contributor

Orange exclamation sign?

@Madis0
Copy link
Collaborator Author

Madis0 commented Sep 27, 2023

Orange exclamation sign?

I thought of something like that - a yellow or orange exclamation sign of some kind.

But that would still be a lose-lose situation: the user may not notice the difference between yellow/orange and red exclamation sign and the server doesn't get to show a good status to the user, despite their (likely) best intentions to disable chat reporting and annoying warning.

@Madis0
Copy link
Collaborator Author

Madis0 commented Sep 28, 2023

Anyway, initial tooltip idea:

This server appears to prevent chat reports. However, it also requires signatures from players. This could either be for simply removing the warning from vanilla users, or for allowing chat reporting (for your chat) by a limited set of users, such as admins. Proceed with caution.

Perhaps initially it can use the same "insecure" icon with just a changed tooltip.

@Madis0 Madis0 changed the title Detect and mark servers that enforce and prevent chat reports Detect and mark servers that enforce but prevent chat reports Nov 16, 2023
@IlyaYezelovsky
Copy link
Contributor

以上字段的简体中文翻译(Simplified Chinese translation)应为:

此服务器似乎禁用了聊天举报。然而,它也要求玩家发送已签名的消息。这可能是为了防止原版客户端在加入服务器时显示警告弹窗,也可能是为了允许部分用户(如管理员)举报玩家的消息。请小心操作。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

4 participants