Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect signing requirement automatically #453

Closed
Madis0 opened this issue Dec 29, 2023 · 1 comment
Closed

Detect signing requirement automatically #453

Madis0 opened this issue Dec 29, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Madis0
Copy link
Collaborator

Madis0 commented Dec 29, 2023

Idea

Detect server's signing requirement without requiring the first message to be sent

Reasoning

Would make it faster to know the status and therefore make decisions based on it; simplify the indicator

Other Information

A competitor mod used this mixin to achieve this (1.20.4):

    @Inject(method = "onServerMetadata(Lnet/minecraft/network/packet/s2c/play/ServerMetadataS2CPacket;)V", at = @At("TAIL"))
    private void onServerMetaData(ServerMetadataS2CPacket packet, CallbackInfo info) {
        if (packet.isSecureChatEnforced()) {
            // implementation
        }
    }

I don't know why, but so far it appears to be spoof-proof, meaning it will not false alert on servers that hide the toast on vanilla clients, such as Hypixel and other viaversion ones.

Related: #437

https://discord.com/channels/757941072449241128/992979156767883375/1190552197101002884

@Madis0 Madis0 added the enhancement New feature or request label Dec 29, 2023
@Madis0
Copy link
Collaborator Author

Madis0 commented Dec 31, 2023

Or [the server] can say signing is required and not refuse to process unsigned messages, likewise converting them to system

So this would still not be feasible.

@Madis0 Madis0 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants