Add option to preserve trailing slash on deletes #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomo-alzetta-aiven
force-pushed
the
giacomo-alzetta-aiven-fix-delete-of-keys-ending-in-slash
branch
6 times, most recently
from
8ff4cc0 to
eeb0570
Compare
giacomo-alzetta-aiven
changed the title
giacomo-alzetta-aiven
force-pushed
the
giacomo-alzetta-aiven-fix-delete-of-keys-ending-in-slash
branch
5 times, most recently
from
6d0e3a5 to
afed708
Compare
Most object storages support having a slash in the object name and rohmu should be able to delete such objects. Let the default behaviour the same but introduce an option `preserve_trailing_slash` which allows to control whether the trailing slash in the key are stripped or not. Added test coverage for `delete_key` and `delete_keys` methods for all transfer types (several had no coverage of it).
giacomo-alzetta-aiven
force-pushed
the
giacomo-alzetta-aiven-fix-delete-of-keys-ending-in-slash
branch
from
afed708 to
3f6fb08
Compare
jadkik
approved these changes
Jan 16, 2025
bugant
approved these changes
Jan 16, 2025
bugant
deleted the
giacomo-alzetta-aiven-fix-delete-of-keys-ending-in-slash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most object storages support having a slash in the object
name and rohmu should be able to delete such objects.
Let the default behaviour the same but introduce an option
preserve_trailing_slashwhich allows to control whether the trailingslash in the key are stripped or not.
About this change - What it does
Resolves: #198
Why this way
Introducing a new flag is backward compatible and preserves the existing behaviour in case this is actually a requirement for some user.
We can later on switch the default value of
preserve_trailing_slashtoTrueif we think we want this behaviour by default.For local/sftp which can't support slashes I opted for explicitly raising an
Errorif the user passespreserve_trailing_slash=Trueinstead of just ignoring the parameter.