object_storage: remove access denied warning for s3 buckets #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Access denied on bucket check` warning messages do not add value, at least they are confusing. A missing `s3:ListBucket` permission does not prohibit writing to a bucket.
| @@ -553,7 +553,8 @@ def check_or_create_bucket(self) -> None: | |||
| if status_code == HTTPStatus.MOVED_PERMANENTLY: | |||
| raise InvalidConfigurationError(f"Wrong region for bucket {self.bucket_name}, check configuration") | |||
| elif status_code == HTTPStatus.FORBIDDEN: | |||
| self.log.warning("Access denied on bucket check, assuming write permissions") | |||
| # Access denied on bucket check, most likely due to missing s3:ListBucket, assuming write permissions | |||
There was a problem hiding this comment.
Suggested change
| # Access denied on bucket check, most likely due to missing s3:ListBucket, assuming write permissions | |
| # Access denied on bucket check, most likely due to missing s3:ListBucket, assuming we have write permissions |
fingon
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
The
Access denied on bucket checkwarning messages do not add value, at least they are confusing. A missings3:ListBucketpermission does not prohibit writing to a bucket.