Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade exporter to be compatible with OpenSearch 2.18.0 #316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vinylen
Copy link
Contributor

@vinylen vinylen commented Nov 6, 2024

Description

Upgrades exporter to be compatible with OpenSearch 2.18.0


  • All my commits include DCO.
    DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using -s option when doing git commit).
    Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.

@vinylen vinylen requested a review from lukas-vlcek as a code owner November 6, 2024 07:23
@ektropy ektropy mentioned this pull request Nov 11, 2024
5 tasks
@Biowoolf
Copy link

Guys! realy need your plugin to be updated to 2.18 version - without it no monitoring on 2.18 clusters built by official helm charts. Your work is very important!
Best regards and hope it will be released soon. =)

@vinylen
Copy link
Contributor Author

vinylen commented Nov 21, 2024

Ping @lukas-vlcek

@lukas-vlcek
Copy link
Collaborator

@vinylen I am on it, I hope it can be done by the end of this week. Monday at the latest.

@Nmishin
Copy link

Nmishin commented Nov 21, 2024

We are really looking forward to it :)

@ArminRadmueller
Copy link

Ping @lukas-vlcek
I can't continue with the upgrade to 2.18 without your Exporter.

@grechaw
Copy link
Contributor

grechaw commented Dec 2, 2024

Should this project be forked? Is there some reason why you've been drawn away from maintenance @lukas-vlcek ? Not to be pushy at all, I'm curious about what the community should expect.

@vinylen
Copy link
Contributor Author

vinylen commented Dec 2, 2024

Should this project be forked? Is there some reason why you've been drawn away from maintenance @lukas-vlcek ? Not to be pushy at all, I'm curious about what the community should expect.

Yes or what if we add more people as maintainers? More of us that can assist with the release of the exporter so it doesn't solely have to be Lukas. Might be tricky since it's under Aiven?

@Pigueiras
Copy link

If the blockers are #295 and #246, maybe just release a 2.18.0.1 version later 👼 ?

@ocastle
Copy link

ocastle commented Dec 5, 2024

Is there an ETA on when this may be completed or an alternative fork for 2.18.0.0 support?

@bjoernr-de
Copy link

If it’s just a version bump, do we have to wait for the plugin 2.18.0.0 release or will the current released version also work with OS 2.18.0? 🤔

@rursprung
Copy link
Contributor

If it’s just a version bump, do we have to wait for the plugin 2.18.0.0 release or will the current released version also work with OS 2.18.0? 🤔

no, it doesn't because - like all plugins using the OpenSearch gradle plugin - it's not yet using a semver range to describe its compatibility with OpenSearch (this requires opensearch-project/OpenSearch#13187 to be implemented).

however, you can always clone the repo locally, adapt it to a new version and create your own build with that. it just won't be an official build.

@vinylen
Copy link
Contributor Author

vinylen commented Dec 11, 2024

@lukas-vlcek Can someone else from Aiven step in and handle this release?

Pinging @bogdanp05 here as well (if that works) since they seem to be the person responsible for Aiven-Open.

I've also emailed [email protected] about this PR last week but i've yet to receive any response.

@damslo
Copy link

damslo commented Dec 13, 2024

Hello, until this PR will be merged, you can use this:
https://github.com/damslo/prometheus-exporter-plugin-for-opensearch/releases/download/2.18.0.0/prometheus-exporter-2.18.0.0.zip

Please don't use it on production, I just built it and uploaded, works in my case, but can't guarantee anything.

@hm2thr33
Copy link

hm2thr33 commented Dec 14, 2024

Hello, until this PR will be merged, you can use this: https://github.com/damslo/prometheus-exporter-plugin-for-opensearch/releases/download/2.18.0.0/prometheus-exporter-2.18.0.0.zip

Please don't use it on production, I just built it and uploaded, works in my case, but can't guarantee anything.

Also works in my case
@damslo Thanks!

xnox added a commit to xnox/os that referenced this pull request Dec 17, 2024
xnox added a commit to wolfi-dev/os that referenced this pull request Dec 17, 2024
…arch 2.18 (#37298)

Upstream release of this plugging is lagging. Bump the compat version
of it by hand. Also see:
-
Aiven-Open/prometheus-exporter-plugin-for-opensearch#317
-
Aiven-Open/prometheus-exporter-plugin-for-opensearch#316

With this change, opensearch 2.18 with this plugin works again; and
deploys in a helm chart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.