Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the exporter to support OpenSearch 2.12.0 #250

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

cesium147
Copy link
Contributor

Description

Describe your PR and add links to relevant issues.


  • All my commits include DCO.
    DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using -s option when doing git commit).
    Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.

@lukas-vlcek
Copy link
Collaborator

I need to look at it, it might be related to java version used in CI. Currently, it is JDK 14
https://github.com/Aiven-Open/prometheus-exporter-plugin-for-opensearch/blob/main/.github/workflows/CI.yml#L15
but we might want to upgrade to 17 or 21.

@amirkkn
Copy link

amirkkn commented Feb 24, 2024

Hi @lukas-vlcek,
we use this exporter in all of our infrastructure and due to a lot of bugs in opensearch v2.11 we must upgrade ASAP. Could you please give me an ETA for the release for 2.12.0? Thanks

@lukas-vlcek
Copy link
Collaborator

I am on it...

Copy link
Collaborator

@lukas-vlcek lukas-vlcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukas-vlcek
Copy link
Collaborator

@cesium147 I had to do one merge from main during review and now the PR passes but can not be merged... I am not sure why...

@lukas-vlcek
Copy link
Collaborator

lukas-vlcek commented Feb 26, 2024

@cesium147 What happened is that I had to upgrade to gradle 8.5 and at the same time I upgraded CI to JDK 17. See https://github.com/Aiven-Open/prometheus-exporter-plugin-for-opensearch/pull/253/commits
Now, your PR somehow does not want to be merged (and rebased) because I did one merge commit...

Do you think you can open a new PR and we will close this one? I am not really sure what is going on. I should not have been using GitHub web UI to manipulate commits... I am sorry.

If you create a new PR, you can add the Java 21 to the CI array like this:

jobs:
  build:
    strategy:
      matrix:
        os: [ubuntu-latest]
        java: [17, 21]

Or you can keep it just on Java 17. Both should be ok.

Other than that the upgrade is looking good.

@lukas-vlcek lukas-vlcek merged commit 54f8ae2 into Aiven-Open:main Feb 26, 2024
3 checks passed
@lukas-vlcek
Copy link
Collaborator

Great, thanks @cesium147 !

@grechaw
Copy link
Contributor

grechaw commented Feb 26, 2024

Thank you all for your work on this. We love upgrading and the exporter is a critical piece of it.

@lukas-vlcek
Copy link
Collaborator

FYI: Plugin version 2.12.0.0 has been released. The following is a forum announcement: https://forum.opensearch.org/t/prometheus-exporter-plugin-2-12-0-0-released/18105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants