Upgrade exporter version to 2.11.1.0 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas-vlcek
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Thanks @Gokul-Radhakrishnan for PR.
It looks good, except we need to change two things:
- The commit needs to be signed (
git -s). Please see the PR description for further info (the PR contains specific steps how you can sign the commit) - Please update the commit message and fix the version (2.1.1 -> 2.11.1, it is perhaps a typo)
Signed-off-by: Gokul R <[email protected]>
Gokul-Radhakrishnan
force-pushed
the
patch-1
branch
from
02e28db to
ed813b0
Compare
Made the changes accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your PR and add links to relevant issues.
DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using
-soption when doinggit commit).Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.