Adding the context to the source connectors #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claudenw
requested changes
Jan 16, 2025
commons/src/main/java/io/aiven/kafka/connect/common/source/input/utils/FilePatternUtils.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/input/utils/FilePatternUtils.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/task/DistributionStrategy.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/task/HashDistributionStrategy.java
Outdated
Show resolved
Hide resolved
| @Override | ||
| public void configureDistributionStrategy(final int maxTasks) { | ||
| this.maxTasks = maxTasks; | ||
| return Math.floorMod(ctx.getStorageKey().hashCode(), maxTasks); |
There was a problem hiding this comment.
This may be too slow a calculation but we can leave it for now. There is a much faster mod calculation in commons collections, but we would have to extract it.
...s/src/main/java/io/aiven/kafka/connect/common/source/task/PartitionDistributionStrategy.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/task/DistributionStrategy.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/task/Context.java
Outdated
Show resolved
Hide resolved
...rce-connector/src/main/java/io/aiven/kafka/connect/s3/source/utils/SourceRecordIterator.java
Outdated
Show resolved
Hide resolved
...rce-connector/src/main/java/io/aiven/kafka/connect/s3/source/utils/SourceRecordIterator.java
Outdated
Show resolved
Hide resolved
aindriu-aiven
force-pushed
the
aindriu-aiven/add-context
branch
7 times, most recently
from
772c511 to
e8452bf
Compare
Claudenw
requested changes
Jan 17, 2025
commons/src/main/java/io/aiven/kafka/connect/common/config/SourceConfigFragment.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/task/Context.java
Outdated
Show resolved
Hide resolved
| @@ -27,18 +28,34 @@ | |||
| * sequentially by the same worker, which can be useful for maintaining order between objects. There are usually fewer | |||
| * workers than tasks, and they will be assigned the remaining tasks as work completes. | |||
| */ | |||
There was a problem hiding this comment.
Is this still a true statement?
There was a problem hiding this comment.
Yes I believe so, i reviewed it before and I do think it is a true statement as every object in the s3 case will only ever be able to be processed by the same task.
There was a problem hiding this comment.
I think it depends upon the strategy implemented.
...ons/src/test/java/io/aiven/kafka/connect/common/source/input/utils/FilePatternUtilsTest.java
Outdated
Show resolved
Hide resolved
s3-source-connector/src/main/java/io/aiven/kafka/connect/s3/source/utils/S3Key.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/input/utils/FilePatternUtils.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/input/utils/FilePatternUtils.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/config/SourceConfigFragment.java
Outdated
Show resolved
Hide resolved
...rce-connector/src/main/java/io/aiven/kafka/connect/s3/source/utils/SourceRecordIterator.java
Outdated
Show resolved
Hide resolved
aindriu-aiven
force-pushed
the
aindriu-aiven/add-context
branch
from
b8e2b2a to
9525803
Compare
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
commons/src/main/java/io/aiven/kafka/connect/common/config/SourceConfigFragment.java
Outdated
Show resolved
Hide resolved
aindriu-aiven
force-pushed
the
aindriu-aiven/add-context
branch
from
b226d52 to
f4a470b
Compare
Claudenw
requested changes
Jan 20, 2025
commons/src/main/java/io/aiven/kafka/connect/common/source/input/utils/FilePatternUtils.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/input/utils/FilePatternUtils.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/input/utils/FilePatternUtils.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/source/task/Context.java
Outdated
Show resolved
Hide resolved
| @@ -27,18 +28,34 @@ | |||
| * sequentially by the same worker, which can be useful for maintaining order between objects. There are usually fewer | |||
| * workers than tasks, and they will be assigned the remaining tasks as work completes. | |||
| */ | |||
There was a problem hiding this comment.
I think it depends upon the strategy implemented.
commons/src/main/java/io/aiven/kafka/connect/common/config/CommonConfig.java
Show resolved
Hide resolved
...connector/src/integration-test/java/io/aiven/kafka/connect/s3/source/AwsIntegrationTest.java
Outdated
Show resolved
Hide resolved
aindriu-aiven
force-pushed
the
aindriu-aiven/add-context
branch
from
5cfecf7 to
aa0ca1e
Compare
Claudenw
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating and refactoring the distribution strategies based on feedback.