Improve S3 Source Integration tests #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing time to be depndent on the test and to take into account if their are more records left to be retrieved before waiting to collect the next batch of records Signed-off-by: Aindriu Lavelle <[email protected]>
RyanSkraba
reviewed
Jan 3, 2025
...ce-connector/src/integration-test/java/io/aiven/kafka/connect/s3/source/IntegrationBase.java
Outdated
Show resolved
Hide resolved
muralibasani
reviewed
Jan 3, 2025
...ce-connector/src/integration-test/java/io/aiven/kafka/connect/s3/source/IntegrationTest.java
Outdated
Show resolved
Hide resolved
muralibasani
reviewed
Jan 3, 2025
...ce-connector/src/integration-test/java/io/aiven/kafka/connect/s3/source/IntegrationBase.java
Outdated
Show resolved
Hide resolved
muralibasani
reviewed
Jan 3, 2025
...ce-connector/src/integration-test/java/io/aiven/kafka/connect/s3/source/IntegrationBase.java
Show resolved
Hide resolved
muralibasani
reviewed
Jan 3, 2025
...ce-connector/src/integration-test/java/io/aiven/kafka/connect/s3/source/IntegrationTest.java
Outdated
Show resolved
Hide resolved
…ming messages. Signed-off-by: Aindriu Lavelle <[email protected]>
aindriu-aiven
force-pushed
the
aindriu-aiven/integration-test-performance
branch
from
a3a366b to
8267489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase performance of the S3 Integration tests by allowing the polling time to be dependent on the test and to take into account if their are more records left to be retrieved before waiting to collect the next batch of records.
This allows the consuming of messages to occur faster if additional messages are already waiting to be retrieved.
This allows different tests to allow a more subtle control of the time to wait before timing out. (previously all tests would wait the maximum 5 minutes even if only waiting for 5 messages from kafka)
This should save 2-3 minutes per Integration test run and allow on a failure run to save between 12-15 minutes on each test run.